Don't panic if setting vdev properties is unsupported for this vdev type #15063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that vdev has valid zap and bail out early. While here, move objid selection out of the loop, it's not going to change. Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
allanjude
approved these changes
Jul 17, 2023
behlendorf
approved these changes
Jul 20, 2023
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jul 21, 2023
Check that vdev has valid zap and bail out early. While here, move objid selection out of the loop, it's not going to change. Reviewed-by: Allan Jude <allan@klarasystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org> Closes openzfs#15063
behlendorf
pushed a commit
that referenced
this pull request
Jul 21, 2023
Check that vdev has valid zap and bail out early. While here, move objid selection out of the loop, it's not going to change. Reviewed-by: Allan Jude <allan@klarasystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org> Closes #15063
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Check that vdev has valid zap and bail out early. While here, move objid selection out of the loop, it's not going to change. Reviewed-by: Allan Jude <allan@klarasystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org> Closes openzfs#15063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return EINVAL instead of panicking if vdev does not support setting vdev properties.
Motivation and Context
Panicking is a really bad way of communicating to user that this vdev type does not support setting vdev properties.
Description
Check that vdev has valid zap and bail out early.
While here, move objid selection out of the loop, it's not going to change.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.