This fix an always false if in the clonefile.c test.
#15128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kay Pedersen <mail@mkwg.de>
oromenahar
changed the title
if in the clonefile test.
oromenahar
changed the title
if in the clonefile test.if in the clonefile.c test.
bwatkinson
approved these changes
Jul 31, 2023
behlendorf
approved these changes
Jul 31, 2023
robn
approved these changes
Jul 31, 2023
robn
added a commit
to robn/clonefile
that referenced
this pull request
Aug 1, 2023
With thanks: openzfs/zfs#15128 Original-patch-by: Kay Pedersen <mail@mkwg.de>
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Aug 1, 2023
Reviewed-by: Brian Atkinson <batkinson@lanl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Rob Norris <rob.norris@klarasystems.com> Signed-off-by: Kay Pedersen <mail@mkwg.de> Closes openzfs#15128
behlendorf
pushed a commit
that referenced
this pull request
Aug 2, 2023
Reviewed-by: Brian Atkinson <batkinson@lanl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Rob Norris <rob.norris@klarasystems.com> Signed-off-by: Kay Pedersen <mail@mkwg.de> Closes #15128
usaleem-ix
pushed a commit
to truenas/zfs
that referenced
this pull request
Aug 17, 2023
Reviewed-by: Brian Atkinson <batkinson@lanl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Rob Norris <rob.norris@klarasystems.com> Signed-off-by: Kay Pedersen <mail@mkwg.de> Closes openzfs#15128
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Reviewed-by: Brian Atkinson <batkinson@lanl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Rob Norris <rob.norris@klarasystems.com> Signed-off-by: Kay Pedersen <mail@mkwg.de> Closes openzfs#15128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small bug fix, which I found while reviewing #15123 this will improve test quality, but just a little bit.
Motivation and Context
this fix a wrong if check in
clonefile.c.Description
No description
How Has This Been Tested?
by hand
Types of changes
Checklist:
Signed-off-by.