Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1.13] ZED slot poweroff backport #15262

Merged

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Backport of ZED slot poweroff functionality for 2.1.13. See #15200 for details.

This functionality is disabled by default.

Description

39347fc (HEAD -> issue-15200-backport, behlendorf/issue-15200-backport) checkstyle: fix action failures
1e5cc95 zed: update zed.d/statechange-slot_off.sh
509212f zed: Add zedlet to power off slot when drive is faulted

How Has This Been Tested?

Backported from master and locally tested.

Checklist:

tonyhutter and others added 3 commits September 11, 2023 13:53
If ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT is enabled in zed.rc, then
power off the drive's slot in the enclosure if it becomes FAULTED.
This can help silence misbehaving drives.  This assumes your drive
enclosure fully supports slot power control via sysfs.

Reviewed-by: @AllKind
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#15200
The statechange-slot_off.sh zedlet which was added in openzfs#15200
needed to be installed so it's included by the packages.

Additional testing has also shown that multiple retries are
often needed for the script to operate reliably.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#15210
Reviewed-by: Don Brady <dev.fs.zfs@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Closes openzfs#15220
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 11, 2023
@behlendorf behlendorf changed the title [2.1.13] ZED slot poweroff backup [2.1.13] ZED slot poweroff backport Sep 12, 2023
@tonyhutter tonyhutter merged commit f1e67cc into openzfs:zfs-2.1.13-staging Sep 12, 2023
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants