Retire z_nr_znodes #15274
Merged
Retire z_nr_znodes #15274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
equivalent change can be made for linux |
amotin
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
It seems z_nr_znodes was added on Linux 12 years ago to implement zpl_nr_cached_objects() VFS callback. I don't see it there any more. FreeBSD code seems just copied it without particular reason during OpenZFS integration. I am not sure removing it is a big saving, but if it makes sense in your bigger plans and we won't need it back, I'm fine about removing it, it is surely not needed now.
Linux code is identical, so I'd do it for both platforms in once PR to not diverge. Once CI passes it, it should probably be fine.
Added in ab26409 ("Linux 3.1 compat, super_block->s_shrink"), with the only consumer which needed the count getting retired in 066e825 ("Linux compat: Minimum kernel version 3.10"). The counter gets in the way of not maintaining the list to begin with. Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
mjguzik
force-pushed
the
no_z_nr_znodes
branch
from
5df4703 to
841ce57
Compare
freebsd-git
pushed a commit
to freebsd/freebsd-src
that referenced
this pull request
Sep 16, 2023
It is not needed and is going away soon(tm), facilitating other changes. See openzfs/zfs#15274
behlendorf
approved these changes
Sep 18, 2023
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Sep 19, 2023
Added in ab26409 ("Linux 3.1 compat, super_block->s_shrink"), with the only consumer which needed the count getting retired in 066e825 ("Linux compat: Minimum kernel version 3.10"). The counter gets in the way of not maintaining the list to begin with. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com> Closes openzfs#15274
behlendorf
pushed a commit
that referenced
this pull request
Sep 19, 2023
Added in ab26409 ("Linux 3.1 compat, super_block->s_shrink"), with the only consumer which needed the count getting retired in 066e825 ("Linux compat: Minimum kernel version 3.10"). The counter gets in the way of not maintaining the list to begin with. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com> Closes #15274
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Added in ab26409 ("Linux 3.1 compat, super_block->s_shrink"), with the only consumer which needed the count getting retired in 066e825 ("Linux compat: Minimum kernel version 3.10"). The counter gets in the way of not maintaining the list to begin with. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com> Closes openzfs#15274
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Feb 3, 2024
It is not needed and is going away soon(tm), facilitating other changes. See openzfs/zfs#15274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.