Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zdb: fix printf() length for uint64_t devid #15606

Merged
merged 1 commit into from
Nov 29, 2023
Merged

zdb: fix printf() length for uint64_t devid #15606

merged 1 commit into from
Nov 29, 2023

Conversation

mmatuska
Copy link
Contributor

@mmatuska mmatuska commented Nov 29, 2023 •
edited
Loading

Signed-off-by: Martin Matuska mm@FreeBSD.org

Motivation and Context

Fixes compilation errors on 32-bit platforms.

Description

The devid uint64_t variable should be represented as PRIu64

How Has This Been Tested?

Compiled on 32-bit platforms.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mmatuska
Copy link
Contributor Author

@robn could you review please?

@mmatuska
zdb: fix printf() length for uint64_t devid
9fcfe8e 
Bug introduced in 213d682

Signed-off-by:  Warner Losh <imp@FreeBSD.org>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Nov 29, 2023
@amotin amotin mentioned this pull request Nov 29, 2023
Merged
13 tasks
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 29, 2023
@behlendorf behlendorf merged commit 1c38cdf into openzfs:master Nov 29, 2023
17 of 25 checks passed
tonyhutter pushed a commit that referenced this pull request Nov 30, 2023
@mmatuska @tonyhutter
zdb: fix printf() length for uint64_t devid
eb34de0 
Bug introduced in 213d682.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Warner Losh <imp@FreeBSD.org>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes #15606
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@mmatuska @lundman
zdb: fix printf() length for uint64_t devid
1d2490e 
Bug introduced in 213d682.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Warner Losh <imp@FreeBSD.org>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#15606
gamanakis pushed a commit to gamanakis/zfs that referenced this pull request Jan 19, 2024
@mmatuska @gamanakis
zdb: fix printf() length for uint64_t devid
42828c6 
Bug introduced in 213d682.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Warner Losh <imp@FreeBSD.org>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#15606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmatuska @behlendorf @amotin