-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZTS: Add Test Case for Block Cloning Replay #15614
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
reviewed
Dec 1, 2023
tests/zfs-tests/tests/functional/block_cloning/block_cloning_replay.ksh
Outdated
Show resolved
Hide resolved
tests/zfs-tests/tests/functional/block_cloning/block_cloning_replay.ksh
Outdated
Show resolved
Hide resolved
tests/zfs-tests/tests/functional/block_cloning/block_cloning_replay_encrypted.ksh
Outdated
Show resolved
Hide resolved
tests/zfs-tests/tests/functional/block_cloning/block_cloning_replay_encrypted.ksh
Outdated
Show resolved
Hide resolved
ixhamza
force-pushed
the
bclone-replay-tests
branch
from
December 1, 2023 02:08
2854453
to
02d3664
Compare
amotin
reviewed
Dec 1, 2023
oromenahar
reviewed
Dec 1, 2023
tests/zfs-tests/tests/functional/block_cloning/block_cloning_replay_encrypted.ksh
Outdated
Show resolved
Hide resolved
oromenahar
suggested changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch and good idea to test this.
oromenahar
reviewed
Dec 1, 2023
tests/zfs-tests/tests/functional/block_cloning/block_cloning_replay_encrypted.ksh
Outdated
Show resolved
Hide resolved
ixhamza
force-pushed
the
bclone-replay-tests
branch
from
December 6, 2023 20:37
02d3664
to
9d5e867
Compare
Updated as per feedback. Please note that added tests will be failing until #15634 is merged. |
#15634 has been merged when you get a moment to rebase this. |
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
ixhamza
force-pushed
the
bclone-replay-tests
branch
from
December 6, 2023 23:17
9d5e867
to
f076afd
Compare
behlendorf
approved these changes
Dec 7, 2023
behlendorf
reviewed
Dec 7, 2023
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
ixhamza
force-pushed
the
bclone-replay-tests
branch
from
December 7, 2023 16:58
f076afd
to
21fe426
Compare
behlendorf
added
Status: Accepted
Ready to integrate (reviewed, tested)
and removed
Status: Code Review Needed
Ready for review and testing
labels
Dec 7, 2023
oromenahar
approved these changes
Dec 8, 2023
behlendorf
pushed a commit
that referenced
this pull request
Dec 9, 2023
Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes #15614
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes openzfs#15614
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes openzfs#15614
mmatuska
pushed a commit
to mmatuska/zfs
that referenced
this pull request
Jan 17, 2024
Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes openzfs#15614
13 tasks
mmatuska
pushed a commit
to mmatuska/zfs
that referenced
this pull request
Jan 18, 2024
Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes openzfs#15614
mmatuska
pushed a commit
to mmatuska/zfs
that referenced
this pull request
Jan 18, 2024
Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes openzfs#15614
mmatuska
pushed a commit
to mmatuska/zfs
that referenced
this pull request
Jan 18, 2024
Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes openzfs#15614
mmatuska
pushed a commit
to mmatuska/zfs
that referenced
this pull request
Jan 18, 2024
Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes openzfs#15614
behlendorf
pushed a commit
that referenced
this pull request
Jan 19, 2024
Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes #15614
behlendorf
pushed a commit
that referenced
this pull request
Jan 19, 2024
Reviewed-by: Kay Pedersen <mail@mkwg.de> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes #15614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two tests (with and without encrypted datasets) when the cloned file is replayed through ZIL.
block_cloning_replay_encrypted
specfically validates the scenario that @amotin fixed under 27d8c23.Types of changes
Checklist:
Signed-off-by
.