Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dkms installation of deb packages created with Alien. #15618

Merged

Conversation

mumbleskates
Copy link
Contributor

@mumbleskates mumbleskates commented Dec 1, 2023

Trivial cherry pick of #15415 (9ce567c) and its followup #15576 (95b68eb), which did not make it into the 2.1 release branch (so the 2.1.14 release was also broken, despite 3 weeks' lag). All concerns relating to the change's suitability defer to the original PRs.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Alien does not honour the %posttrans hook.
So move the dkms uninstall/install scripts to the
 %pre/%post hooks in case of package install/upgrade.
In case of package removal, handle that in %preun.
Add removal of all old dkms modules.
Add checking for broken 'dkms status'. Handle that as
good as possible and warn the user about it.
Also add more verbose messages about what we are doing.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mart Frauenlob <AllKind@fastest.cc>
Closes openzfs#15415
(cherry picked from commit 9ce567c)
@AllKind
Copy link
Contributor

AllKind commented Dec 1, 2023

Well, I tried... #15601 (comment)

@behlendorf
Copy link
Contributor

@mumbleskates @AllKind thank you both. We can get this change in to the next release. We wanted to keep the number of changes in 2.1.14 to the minimum. @mumbleskates can you also add the follow up commit 95b68eb to this PR.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 1, 2023
If all zfs dkms modules have been removed, a shell-init error message
may appear, because /var/lib/dkms/zfs does no longer exist.
Resolve this by leaving the directory earlier on.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mart Frauenlob <AllKind@fastest.cc>
Closes openzfs#15576
@mumbleskates
Copy link
Contributor Author

can you also add the follow up commit 95b68eb to this PR.

done.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 2, 2023
@behlendorf behlendorf merged commit 74da5eb into openzfs:zfs-2.1.15-staging Dec 5, 2023
6 of 12 checks passed
@mumbleskates
Copy link
Contributor Author

thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants