Fix dkms installation of deb packages created with Alien. #15618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alien does not honour the %posttrans hook. So move the dkms uninstall/install scripts to the %pre/%post hooks in case of package install/upgrade. In case of package removal, handle that in %preun. Add removal of all old dkms modules. Add checking for broken 'dkms status'. Handle that as good as possible and warn the user about it. Also add more verbose messages about what we are doing. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Mart Frauenlob <AllKind@fastest.cc> Closes openzfs#15415 (cherry picked from commit 9ce567c)
|
Well, I tried... #15601 (comment) |
|
@mumbleskates @AllKind thank you both. We can get this change in to the next release. We wanted to keep the number of changes in 2.1.14 to the minimum. @mumbleskates can you also add the follow up commit 95b68eb to this PR. |
If all zfs dkms modules have been removed, a shell-init error message may appear, because /var/lib/dkms/zfs does no longer exist. Resolve this by leaving the directory earlier on. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Mart Frauenlob <AllKind@fastest.cc> Closes openzfs#15576
done. |
behlendorf
approved these changes
Dec 2, 2023
behlendorf
added
Status: Accepted
|
thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial cherry pick of #15415 (9ce567c) and its followup #15576 (95b68eb), which did not make it into the 2.1 release branch (so the 2.1.14 release was also broken, despite 3 weeks' lag). All concerns relating to the change's suitability defer to the original PRs.
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.