Remove list_size struct member from list implementation #15812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwatkinson
suggested changes
Jan 23, 2024
MigeljanImeri
force-pushed
the
remove_list_size
branch
from
2f38ed7 to
b0eb8e5
Compare
amotin
approved these changes
Jan 25, 2024
Removed the list_size struct member as it was only used in a single assertion, as mentioned in PR openzfs#15478. Signed-off-by: MigeljanImeri <imerimigel@gmail.com>
Removed the list_size struct member as it was only used in a single assertion, as mentioned in PR openzfs#15478. Signed-off-by: MigeljanImeri <imerimigel@gmail.com>
MigeljanImeri
force-pushed
the
remove_list_size
branch
from
b0eb8e5 to
4ed348a
Compare
bwatkinson
approved these changes
Jan 26, 2024
amotin
approved these changes
Jan 26, 2024
behlendorf
approved these changes
Jan 26, 2024
|
When merging I intentionally squashed these two commits. This is such a small change I don't think we need to leave the kernel and user portions split just in case we end up wanting to revert part of it. |
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 13, 2024
Removed the list_size struct member as it was only used in a single assertion, as mentioned in PR openzfs#15478. Reviewed-by: Brian Atkinson <batkinson@lanl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: MigeljanImeri <imerimigel@gmail.com> Closes openzfs#15812
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 13, 2024
Removed the list_size struct member as it was only used in a single assertion, as mentioned in PR openzfs#15478. Reviewed-by: Brian Atkinson <batkinson@lanl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: MigeljanImeri <imerimigel@gmail.com> Closes openzfs#15812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In a previous pull request I opened (#15478), I added an additional counter to track the number of pending sync IO operations as it wasn't properly being tracked before. This adds extra space requirements to the vdev_queue struct and to counteract this increase it was suggested to remove the list_size struct member as it was only used in a few asserts in the code.
Description
I removed the list_size struct member in the list implementations in two separate commits, in order to keep the kernel list and the user-space list changes separate, in case this has to be reverted in the future.
How Has This Been Tested?
I ran zloop.sh and no apparent crashes were seen.
Types of changes
Checklist:
Signed-off-by.