Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/zfs-build.m4: sort vendors & add Alpine Linux bash-completion path #16164

Closed
wants to merge 2 commits into from

Conversation

omnivagant
Copy link
Contributor

It is often easier to find what you are looking for when it is alphabetically sorted.

This is what I suggested in #16163 and also an alternative to that PR, since I added a similar commit to this one.

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the additional cleanup!

@behlendorf
Copy link
Contributor

behlendorf commented May 9, 2024

Can you please just add your https://github.com/openzfs/zfs/blob/master/.github/CONTRIBUTING.md#signed-off-by to these commits so they can be merged,.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) Status: Revision Needed Changes are required for the PR to be accepted labels May 9, 2024
Signed-off-by: omni <omni+vagant@hack.org>
Signed-off-by: omni <omni+vagant@hack.org>
@behlendorf behlendorf removed the Status: Revision Needed Changes are required for the PR to be accepted label May 16, 2024
behlendorf pushed a commit that referenced this pull request May 17, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: omni <omni+vagant@hack.org>
Closes #16164
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: omni <omni+vagant@hack.org>
Closes openzfs#16164
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: omni <omni+vagant@hack.org>
Closes openzfs#16164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants