FreeBSD: Add const qualifier to members of struct opensolaris_utsname #16210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These members have directly references to the global variables exposed by the kernel. They are not going to be changed by this kernel module. Signed-off-by: Zhenlei Huang <zlei@FreeBSD.org>
behlendorf
approved these changes
May 29, 2024
behlendorf
added
Status: Accepted
|
@behlendorf Thanks ! |
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 4, 2024
These members have directly references to the global variables exposed by the kernel. They are not going to be changed by this kernel module. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Zhenlei Huang <zlei@FreeBSD.org> Closes openzfs#16210
rkojedzinszky
pushed a commit
to dravanet/openzfs-zfs
that referenced
this pull request
Nov 4, 2024
These members have directly references to the global variables exposed by the kernel. They are not going to be changed by this kernel module. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Zhenlei Huang <zlei@FreeBSD.org> Closes openzfs#16210
ptr1337
pushed a commit
to CachyOS/zfs
that referenced
this pull request
Nov 21, 2024
These members have directly references to the global variables exposed by the kernel. They are not going to be changed by this kernel module. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Zhenlei Huang <zlei@FreeBSD.org> Closes openzfs#16210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
These members have directly references to the global variables exposed by the kernel. They are not going to be changed by this kernel module.
No functional change intended.
How Has This Been Tested?
Apply the patch on top of FreeBSD src tree
sys/contrib/openzfs, build and reboot with new kernel / zfs module .Types of changes
This should unbreak the build with upcoming change of FreeBSD https://reviews.freebsd.org/D45227 . But even without that change, this should be fine.
Checklist:
Signed-off-by.