Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify issig(). #16225

Merged
merged 1 commit into from
May 29, 2024
Merged

Simplify issig(). #16225

merged 1 commit into from
May 29, 2024

Conversation

pjd
Copy link
Contributor

@pjd pjd commented May 24, 2024

We always call it twice with JUSTLOOKING and then FORREAL.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf requested a review from pcd1193182 May 25, 2024 02:06
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 25, 2024
@pjd
Simplify issig().
98701c1 
We always call it twice with JUSTLOOKING and then FORREAL.

Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 29, 2024
@behlendorf behlendorf merged commit 01c8efd into openzfs:master May 29, 2024
24 of 25 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@pjd @lundman
Simplify issig().
e998d0a 
We always call it twice with JUSTLOOKING and then FORREAL.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#16225
ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 14, 2024
@pjd @tonyhutter
Simplify issig().
0194d23 
We always call it twice with JUSTLOOKING and then FORREAL.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#16225
ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 21, 2024
@pjd @tonyhutter
Simplify issig().
a6198f3 
We always call it twice with JUSTLOOKING and then FORREAL.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#16225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@pcd1193182 pcd1193182 Awaiting requested review from pcd1193182

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjd @behlendorf