Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 6.10 compat: Fix zvol NULL pointer deference #16453

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Linux 6.10 compat: Fix zvol NULL pointer deference #16453

merged 1 commit into from
Aug 15, 2024

Conversation

tonyhutter
Copy link
Contributor

@tonyhutter tonyhutter commented Aug 15, 2024 •
edited
Loading

Motivation and Context

Fix a NULL ptr de-reference in alloc_class_013_pos on Fedora 40 w/6.10.3 kernel.

Description

Setup the disk queue pointer before calling blk_queue_set_write_cache() in the zvol code.

How Has This Been Tested?

alloc_class_013_pos passes with this PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@tonyhutter tonyhutter mentioned this pull request Aug 15, 2024
Merged
13 tasks
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Aug 15, 2024
@tonyhutter
Linux 6.10 compat: Fix zvol NULL pointer deference
5631319 
zvol_alloc_non_blk_mq()->blk_queue_set_write_cache() needs the disk
queue setup to prevent a NULL pointer deference.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
@behlendorf behlendorf merged commit fb43266 into openzfs:master Aug 15, 2024
5 of 7 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@tonyhutter @lundman
Linux 6.10 compat: Fix zvol NULL pointer deference
05dbd54 
zvol_alloc_non_blk_mq()->blk_queue_set_write_cache() needs the disk
queue setup to prevent a NULL pointer deference.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#16453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyhutter @behlendorf