Fix handling of DNS names with '-' in them for sharenfs #16529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An old FreeBSD bugzilla report PR#168158 notes that DNS names with '-'s in them cannot be used for the sharenfs property. This patch fixes the parsing of these DNS names. The only negative affect this patch might have is that, if a user has incorrectly separated options with a '-' the sharenfs setting will no longer work once this patch is applied. Signed-off-by: Rick Macklem <rmacklem@uoguelph.ca>
amotin
approved these changes
Sep 11, 2024
|
On Wed, Sep 11, 2024 at 7:35 AM Alexander Motin ***@***.***> wrote:
CAUTION: This email originated from outside of the University of Guelph.
Do not click links or open attachments unless you recognize the sender and
know the content is safe. If in doubt, forward suspicious emails to
***@***.***
***@***.**** approved this pull request.
I can't think why "-" would be used as separator. I am a bit worrying
about possible syntax change, but hopefully it makes more good than harm.
Since the man page (zfsprops) defines sharenfs as a ',' separated list, I
think we are ok.
(And DNS names with '-' in them are pretty common.)
rick
… —
Reply to this email directly, view it on GitHub
<#16529 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APNAL2WHIS6RADWHDKND673ZWBIK5AVCNFSM6AAAAABN7TWZM2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJXGM2DIMBZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
behlendorf
approved these changes
Sep 17, 2024
ptr1337
pushed a commit
to CachyOS/zfs
that referenced
this pull request
Nov 14, 2024
An old FreeBSD bugzilla report PR#168158 notes that DNS names with '-'s in them cannot be used for the sharenfs property. This patch fixes the parsing of these DNS names. The only negative affect this patch might have is that, if a user has incorrectly separated options with a '-' the sharenfs setting will no longer work once this patch is applied. Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Rick Macklem <rmacklem@uoguelph.ca> Closes openzfs#16529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Without this patch, the sharenfs property cannot have DNS names with '-' in them on FreeBSD.
This was reported to FreeBSD in a bugzilla report#168158 over 10 years ago.
Description
Change the parser slightly so that '-' no longer is an option separator and
then strip any leading '-' off of the option (since it is no longer stripped out
as a separator).
How Has This Been Tested?
Did a "zfs set sharenfs" with a '-' in the DNS name and then looked at
the resultant /etc/zfs/exports file.
The only negative effect might be that, if a bogus sharenfs setting used
'-' to separate options, it will no longer work with this patch.
Types of changes
Checklist:
Signed-off-by.