-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump SONAME of libzfs and libzpool before 2.3.0 release #16609
Conversation
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
The ABI of libzfs and libzpool have breaking changes since last SONAME bump in commit fe6babc: * libzfs: `zpool_print_unsup_feat` removed (used by zpool cmd). * libzpool: multiple `ddt_*` symbols removed (used by zdb cmd). Bump them to avoid ABI breakage. See: openzfs#11817 ZFS-CI-Type: quick Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Do any of the ABI changes affect programs shipped outside of OpenZFS (i.e., are any external consumers affected?)? I assume that zpool and zdb are always packaged with OpenZFS, so they will always be packaged with a corresponding libzfs and libzpool and thus never break? |
Yes. For example, truenas's https://github.com/truenas/py-libzfs links to libzfs. There might be other tools leveraging these libraries.
Executables and libraries are separately packaged in both RPM / DEB, so they are theoretically not always bundled together. Although executable packages can specify dependencies on specific library versions (and this is what we are doing now both in upstream and distros), it is always safer (and required by most distro policies) to have a SONAME bump whenever ABI have breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes a SONAME version bump is definitely in order.
The ABI of libzfs and libzpool have breaking changes since last SONAME bump in commit fe6babc: * libzfs: `zpool_print_unsup_feat` removed (used by zpool cmd). * libzpool: multiple `ddt_*` symbols removed (used by zdb cmd). Bump them to avoid ABI breakage. See: #11817 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Closes #16609
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Closes openzfs#16609
The ABI of libzfs and libzpool have breaking changes since last SONAME bump in commit fe6babc: * libzfs: `zpool_print_unsup_feat` removed (used by zpool cmd). * libzpool: multiple `ddt_*` symbols removed (used by zdb cmd). Bump them to avoid ABI breakage. See: openzfs#11817 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Closes openzfs#16609
Motivation and Context
The ABI of libzfs and libzpool have breaking changes since last SONAME bump in commit fe6babc:
zpool_print_unsup_feat
removed (used by zpool cmd).ddt_*
symbols removed (used by zdb cmd), and many more.Bump them to avoid ABI breakage.
See: #11817
cc @behlendorf
Description
See my commits. And here's the
dpkg-gensymbols
output comparing symbols from 2.3.0-rc1 to 2.2.6, for reference:zfs-symbols.patch
How Has This Been Tested?
Compiled on my machine. Wait for CI run.
Types of changes
Checklist:
Signed-off-by
.