Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: resilver_restart_001.ksh restore defaults #16618

Merged
merged 1 commit into from
Oct 8, 2024
Merged

ZTS: resilver_restart_001.ksh restore defaults #16618

merged 1 commit into from
Oct 8, 2024

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Fix minor issue noticed while reviewing the test case.

@snajpa please review.

Description

Update resilver_restart_001.ksh to restore the default resilver_defer_percent when the test completes.

How Has This Been Tested?

Will be tested by the CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Component: Test Suite Indicates an issue with the test framework or a test case label Oct 7, 2024
snajpa
snajpa approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@snajpa snajpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; and thank you, I'll try to be more mindful of the whole file next time, completely missed this

@behlendorf
ZTS: resilver_restart_001.ksh restore defaults
c932921 
Update resilver_restart_001.ksh to restore the default
resilver_defer_percent when the test completes.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf force-pushed the zts-resilver_restart_001 branch from 2a37d16 to c932921 Compare October 8, 2024 02:15
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Component: Test Suite Indicates an issue with the test framework or a test case labels Oct 8, 2024
@behlendorf behlendorf merged commit 75dda92 into openzfs:master Oct 8, 2024
19 of 20 checks passed
behlendorf added a commit to behlendorf/zfs that referenced this pull request Oct 9, 2024
@behlendorf
ZTS: resilver_restart_001.ksh restore defaults
10f46d2 
Update resilver_restart_001.ksh to restore the default
resilver_defer_percent when the test completes.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Pavel Snajdr <snajpa@snajpa.net>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#16618
robn pushed a commit to robn/zfs that referenced this pull request Nov 5, 2024
@behlendorf @tonyhutter
ZTS: resilver_restart_001.ksh restore defaults
b53fa28 
Update resilver_restart_001.ksh to restore the default
resilver_defer_percent when the test completes.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Pavel Snajdr <snajpa@snajpa.net>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#16618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhutter tonyhutter tonyhutter left review comments

@mcmilk mcmilk mcmilk approved these changes

@snajpa snajpa snajpa approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@behlendorf @snajpa @mcmilk @tonyhutter