Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency install on Debian 11 #16683

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix dependency install on Debian 11 #16683

merged 1 commit into from
Oct 24, 2024

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Oct 24, 2024 •
edited
Loading

Motivation and Context

Adding cryptsetup breaks some dialog things on Debian 11.
This fix will apply some workaround for it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mcmilk
Fix dependency install on Debian 11
627c4a3 
Adding cryptsetup breaks some dialog things on Debian 11.
Apply some workaround for it.

Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
@mcmilk mcmilk mentioned this pull request Oct 24, 2024
Merged
13 tasks
@mcmilk
Copy link
Contributor Author

mcmilk commented Oct 24, 2024

On my actions page the full ZTS will be run, it looks good: https://github.com/mcmilk/zfs/actions/runs/11505941169

@tonyhutter tonyhutter merged commit 2e4e092 into openzfs:master Oct 24, 2024
14 checks passed
@mcmilk mcmilk deleted the fix-debian11 branch October 25, 2024 20:11
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Nov 1, 2024
@mcmilk @behlendorf
Fix dependency install on Debian 11 (openzfs#16683)
77d8197 
Adding cryptsetup breaks some dialog things on Debian 11.
Apply some workaround for it.

Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
robn pushed a commit to robn/zfs that referenced this pull request Nov 5, 2024
@mcmilk @tonyhutter
Fix dependency install on Debian 11 (openzfs#16683)
4635fce 
Adding cryptsetup breaks some dialog things on Debian 11.
Apply some workaround for it.

Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
@tonyhutter tonyhutter mentioned this pull request Nov 6, 2024
Merged
13 tasks
ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 14, 2024
@mcmilk @tonyhutter
Fix dependency install on Debian 11 (openzfs#16683)
bdd1f72 
Adding cryptsetup breaks some dialog things on Debian 11.
Apply some workaround for it.

Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhutter tonyhutter tonyhutter approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcmilk @gmelikov @tonyhutter