Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing parenthesis in VERIFYF() #16826

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add missing parenthesis in VERIFYF() #16826

merged 1 commit into from
Dec 3, 2024

Conversation

amotin
Copy link
Member

@amotin amotin commented Dec 1, 2024

Without them the order of operations might get unexpected.

How Has This Been Tested?

Used ASSERTF() with complicated expression and observed Clang complains, fixed by the change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Add missing parenthesis in VERIFYF()
4c791f8 
Without them the order of operations might get unexpected.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Dec 1, 2024
@amotin amotin requested a review from rincebrain December 1, 2024 22:52
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 3, 2024
@behlendorf behlendorf merged commit 3e9ba0f into openzfs:master Dec 3, 2024
24 checks passed
@amotin amotin deleted the verifyf branch December 3, 2024 01:00
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Dec 3, 2024
@amotin @behlendorf
Add missing parenthesis in VERIFYF()
17cdb7a 
Without them the order of operations might get unexpected.

Reviewed-by: Adam Moss <c@yotes.com>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#16826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdmoss adamdmoss adamdmoss approved these changes

@lundman lundman lundman approved these changes

@robn robn robn approved these changes

@rincebrain rincebrain Awaiting requested review from rincebrain

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amotin @robn @lundman @adamdmoss @behlendorf