Userspace can pass zero length segments via writev/readv #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Userspace can trigger an assertion by passing a zero-length segment when assertions are enabled: [27961.614792] VERIFY3(skip < iov->iov_len) failed (0 < 0) [27961.614795] PANIC at zfs_uio.c:187:uio_prefaultpages() [27961.614796] Showing stack for process 99921 [27961.614798] CPU: 7 PID: 99921 Comm: cmake Tainted: P OE 4.1.3 #2 [27961.614799] Hardware name: Supermicro X10SAE/X10SAE, BIOS 3.0 05/20/2015 [27961.614800] 00000000000000bb ffff8804346838c8 ffffffff815e7d05 0000000000000007 [27961.614802] ffffffffa0a01451 ffff8804346838d8 ffffffffa07f96b4 ffff880434683a68 [27961.614803] ffffffffa07f977b ffff880426e2c600 ffff880426e2c6d0 ffff880400000030 [27961.614805] Call Trace: [27961.614811] [<ffffffff815e7d05>] dump_stack+0x45/0x57 [27961.614830] [<ffffffffa07f96b4>] spl_dumpstack+0x44/0x50 [spl] [27961.614834] [<ffffffffa07f977b>] spl_panic+0xbb/0x100 [spl] [27961.614865] [<ffffffffa0b578cc>] ? zap_add+0xec/0x1a0 [zfs] [27961.614886] [<ffffffffa0b628ca>] ? zfs_link_create+0x38a/0x600 [zfs] [27961.614888] [<ffffffff815eb516>] ? mutex_lock+0x16/0x40 [27961.614904] [<ffffffffa0b15f61>] ? refcount_add_many+0xa1/0x140 [zfs] [27961.614908] [<ffffffffa09fdb14>] uio_prefaultpages+0x134/0x140 [zcommon] [27961.614930] [<ffffffffa0b807bd>] zfs_write+0x1fd/0xe80 [zfs] [27961.614934] [<ffffffff8124db2d>] ? security_transition_sid+0x2d/0x40 [27961.614950] [<ffffffffa0b17120>] ? rrm_exit+0x50/0xa0 [zfs] [27961.614951] [<ffffffff815eb516>] ? mutex_lock+0x16/0x40 [27961.614967] [<ffffffffa0b17120>] ? rrm_exit+0x50/0xa0 [zfs] [27961.614988] [<ffffffffa0b79276>] ? zfs_open+0x86/0x120 [zfs] [27961.614990] [<ffffffff811c5d87>] ? inode_to_bdi+0x27/0x60 [27961.614992] [<ffffffff811552e9>] ? file_ra_state_init+0x19/0x30 [27961.615014] [<ffffffffa0ba004f>] zpl_write_common_iovec+0x7f/0x110 [zfs] [27961.615035] [<ffffffffa0ba0f00>] zpl_iter_write+0xa0/0xd0 [zfs] [27961.615037] [<ffffffff8119b8b9>] do_iter_readv_writev+0x59/0x80 [27961.615061] [<ffffffffa0ba02f0>] ? zpl_read+0xa0/0xa0 [zfs] [27961.615063] [<ffffffff8119bf8b>] do_readv_writev+0x11b/0x260 [27961.615093] [<ffffffffa0ba0e60>] ? zpl_compat_ioctl+0x10/0x10 [zfs] [27961.615096] [<ffffffff811aba1f>] ? putname+0x6f/0x80 [27961.615098] [<ffffffff8119c159>] vfs_writev+0x39/0x50 [27961.615100] [<ffffffff8119ce9a>] SyS_writev+0x4a/0xe0 [27961.615103] [<ffffffff815ed75b>] system_call_fastpath+0x16/0x6e The solution is to delete the assertion. This could potentially occur in uiomove as well, which contains analogous assertions that appear similarly unnecessary, so we remove those as well. Closes openzfs#3792 Reported-by: Jonathan Vasquez <jvasquez1011@gmail.com> Signed-off-by: Richard Yao <ryao@gentoo.org>
ryao
force-pushed
the
uio_prefaultpages
branch
from
13cb392 to
6edacba
Compare
|
Merged as: b815ec3 Userspace can pass zero length segments via writev/readv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Userspace can trigger an assertion by passing a zero-length segment when
assertions are enabled:
[27961.614792] VERIFY3(skip < iov->iov_len) failed (0 < 0)
[27961.614795] PANIC at zfs_uio.c:187:uio_prefaultpages()
[27961.614796] Showing stack for process 99921
[27961.614798] CPU: 7 PID: 99921 Comm: cmake Tainted: P OE 4.1.3 #2
[27961.614799] Hardware name: Supermicro X10SAE/X10SAE, BIOS 3.0 05/20/2015
[27961.614800] 00000000000000bb ffff8804346838c8 ffffffff815e7d05 0000000000000007
[27961.614802] ffffffffa0a01451 ffff8804346838d8 ffffffffa07f96b4 ffff880434683a68
[27961.614803] ffffffffa07f977b ffff880426e2c600 ffff880426e2c6d0 ffff880400000030
[27961.614805] Call Trace:
[27961.614811] [] dump_stack+0x45/0x57
[27961.614830] [] spl_dumpstack+0x44/0x50 [spl]
[27961.614834] [] spl_panic+0xbb/0x100 [spl]
[27961.614865] [] ? zap_add+0xec/0x1a0 [zfs]
[27961.614886] [] ? zfs_link_create+0x38a/0x600 [zfs]
[27961.614888] [] ? mutex_lock+0x16/0x40
[27961.614904] [] ? refcount_add_many+0xa1/0x140 [zfs]
[27961.614908] [] uio_prefaultpages+0x134/0x140 [zcommon]
[27961.614930] [] zfs_write+0x1fd/0xe80 [zfs]
[27961.614934] [] ? security_transition_sid+0x2d/0x40
[27961.614950] [] ? rrm_exit+0x50/0xa0 [zfs]
[27961.614951] [] ? mutex_lock+0x16/0x40
[27961.614967] [] ? rrm_exit+0x50/0xa0 [zfs]
[27961.614988] [] ? zfs_open+0x86/0x120 [zfs]
[27961.614990] [] ? inode_to_bdi+0x27/0x60
[27961.614992] [] ? file_ra_state_init+0x19/0x30
[27961.615014] [] zpl_write_common_iovec+0x7f/0x110 [zfs]
[27961.615035] [] zpl_iter_write+0xa0/0xd0 [zfs]
[27961.615037] [] do_iter_readv_writev+0x59/0x80
[27961.615061] [] ? zpl_read+0xa0/0xa0 [zfs]
[27961.615063] [] do_readv_writev+0x11b/0x260
[27961.615093] [] ? zpl_compat_ioctl+0x10/0x10 [zfs]
[27961.615096] [] ? putname+0x6f/0x80
[27961.615098] [] vfs_writev+0x39/0x50
[27961.615100] [] SyS_writev+0x4a/0xe0
[27961.615103] [] system_call_fastpath+0x16/0x6e
The solution is to delete the assertion. This could potentially occur in
uiomove as well, which contains analogous assertions that appear
similarly unnecessary, so we remove those as well.
Closes #3792
Reported-by: Jonathan Vasquez jvasquez1011@gmail.com
Signed-off-by: Richard Yao ryao@gentoo.org