Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate LVM volume groups before looking for zpools #4029

Closed
wants to merge 1 commit into from
Closed

Activate LVM volume groups before looking for zpools #4029

wants to merge 1 commit into from

Conversation

benalbrecht
Copy link
Contributor

Using the script by @jgoerzen from zfsonlinux/pkg-zfs#102.

I'm not sure, whether this should be an extra script.
Maybe it would be better to add this functionality to the main zfs initramfs script?

@sempervictus
Copy link
Contributor

Would this cause issues for the people running VGs out of their ZVOLs?

@behlendorf
Copy link
Contributor

Aside from the error message this LGTM. Can anyone, @jgoerzen, @benalbrecht, comment on how much real user and testing has been done with this script?

@jgoerzen
Copy link

jgoerzen commented Dec 7, 2015

I put it on a couple of Debian systems back when I submitted that bug report, and it has been working fine. Other than that, I can't say.

@behlendorf
Copy link
Contributor

@benalbrecht if you can address the patch comments and refresh this pull request and verify it works as expected we can likely get this merged.

@benalbrecht
Copy link
Contributor Author

addressed the comments and rebased.
the script still works as expected.

kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this pull request Dec 22, 2015
@benalbrecht @kernelOfTruth
Activate LVM volume groups before looking for zpools.
3ede623 
Original-patch-by: @jgoerzen
Signed-off-by: Benjamin Albrecht <git@albrecht.io>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes zfsonlinux/pkg-zfs#102
Closes openzfs#4029
ryao pushed a commit to ryao/zfs that referenced this pull request Jan 4, 2016
@benalbrecht @ryao
Activate LVM volume groups before looking for zpools.
db5938f 
Original-patch-by: @jgoerzen
Signed-off-by: Benjamin Albrecht <git@albrecht.io>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes zfsonlinux/pkg-zfs#102
Closes openzfs#4029
goulvenriou pushed a commit to Alyseo/zfs that referenced this pull request Jan 17, 2016
@benalbrecht
Activate LVM volume groups before looking for zpools.
3474ba8 
Original-patch-by: @jgoerzen
Signed-off-by: Benjamin Albrecht <git@albrecht.io>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes zfsonlinux/pkg-zfs#102
Closes openzfs#4029
goulvenriou pushed a commit to Alyseo/zfs that referenced this pull request Feb 4, 2016
@benalbrecht
Activate LVM volume groups before looking for zpools.
20f1f1d 
Original-patch-by: @jgoerzen
Signed-off-by: Benjamin Albrecht <git@albrecht.io>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes zfsonlinux/pkg-zfs#102
Closes openzfs#4029
@zeigerpuppy
Copy link

As @sempervictus mentioned, I think this change is having a detrimental effect on mounting LVM groups on top of ZFS. In Debian 9 (zfs-dkms 0.7.11-1~bpo9+1), I am finding that I have to run vgscan again after boot or else the LVM volumes are not enumerated.
I am using LVM volumes for docker machines, so this also causes docker to fail to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benalbrecht @sempervictus @behlendorf @jgoerzen @zeigerpuppy