Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenZFS 7786 - zfs`vdev_online() needs better notification about state changes #6074

Closed
wants to merge 1 commit into from
Closed

OpenZFS 7786 - zfs`vdev_online() needs better notification about state changes #6074

wants to merge 1 commit into from

Conversation

bunder2015
Copy link
Contributor

@bunder2015 bunder2015 commented Apr 26, 2017 •
edited
Loading

Authored by: Yuri Pankov yuri.pankov@nexenta.com
Reviewed by: Matthew Ahrens mahrens@delphix.com
Reviewed by: George Wilson george.wilson@delphix.com
Approved by: Albert Lee trisk@forkgnu.org
Ported-by: bunder2015 omfgbunder@gmail.com

OpenZFS-issue: https://www.illumos.org/issues/7786
OpenZFS-commit: http://github.com/openzfs/openzfs/commit/db8498f

Motivation and Context

Found this on the list of unported commits from the OpenZFS tracker.

How Has This Been Tested?

Tested on VM after making the required changes to module/zfs/vdev.c

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@mention-bot
Copy link

@bunder2015, thanks for your PR! By analyzing the history of the files in this pull request, we identified @behlendorf, @grwilson and @tonyhutter to be potential reviewers.

@bunder2015 bunder2015 changed the title OpenZFS 7786 - zfs`vdev_online() needs better... OpenZFS 7786 - zfs`vdev_online() needs better notification about state changes Apr 26, 2017
@bunder2015
OpenZFS 7786 - zfs`vdev_online() needs better...
ab666fc 
... notification about state changes

Authored by: Yuri Pankov <yuri.pankov@nexenta.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Approved by: Albert Lee <trisk@forkgnu.org>
Ported-by: bunder2015 <omfgbunder@gmail.com>

OpenZFS-issue: https://www.illumos.org/issues/7786
OpenZFS-commit: http://github.com/openzfs/openzfs/commit/db8498f
@bunder2015
Copy link
Contributor Author

Rebased on master, mainly to re-run ubuntu 14.04 i686, as it had a random failure with rsend_019_pos.

@bunder2015
Copy link
Contributor Author

bunder2015 commented Apr 28, 2017 •
edited
Loading

edit: I filed a bug for the test case that failed as I see it on my VM as well.

@behlendorf behlendorf requested a review from tonyhutter April 28, 2017 15:55
@bunder2015 bunder2015 mentioned this pull request May 1, 2017
Closed
@behlendorf behlendorf closed this in 153b228 May 1, 2017
@bunder2015 bunder2015 deleted the openzfs-7786 branch May 2, 2017 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@dinatale2 dinatale2 dinatale2 approved these changes

@tonyhutter tonyhutter Awaiting requested review from tonyhutter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bunder2015 @mention-bot @behlendorf @dinatale2