Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback for changes to zfs_multihost_interval #6387

Closed
wants to merge 2 commits into from
Closed

Add callback for changes to zfs_multihost_interval #6387

wants to merge 2 commits into from

Conversation

ofaaland
Copy link
Contributor

@ofaaland ofaaland commented Jul 21, 2017 •
edited
Loading

Description

Add a callback to wake all running mmp threads when
zfs_multihost_interval is changed.

Added a test in the ZTS under mmp to verify the new functionality is
working.

Added a test to ztest which starts and stops mmp threads, and calls into
the code to signal sleeping mmp threads, to test for deadlocks or
similar locking issues.

Motivation and Context

This change is necessary when zfs_multihost_interval is changed from
a very large value to a significantly lower one, while pools are imported that have the
multihost property enabled.

Without this commit, the mmp thread does not wake up and detect the new
interval until after it has waited the old multihost interval time. A
user monitoring mmp writes via the provided kstat would be led to
believe that the setting change did not work.

How Has This Been Tested?

Hand testing + a new ZTS test case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@ofaaland ofaaland force-pushed the b_multihost_interval_cb branch 2 times, most recently from a53c24a to 46785a7 Compare July 21, 2017 22:21
ofaaland added 2 commits July 22, 2017 07:04
@ofaaland
Revert "Fix vdev_probe() call outside SCL_STATE_ALL lock"
45b45a4 
This reverts commit cc9c6bc.

The async zios executed via zio_nowait() are protected by SCL_ZIO which
is taken by the zio pipeline itself in the IO_START stage and released
in the IO_ASSES stage if zio->io_flag does not contain CONFIG_WRITER.

In addition, the vdev_probe() patch causes ztest to fail consistently.

Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
@ofaaland
Add callback for zfs_multihost_interval
ca31452 
Add a callback to wake all running mmp threads when
zfs_multihost_interval is changed.

This is necessary when the interval is changed from a very large value
to a significantly lower one, while pools are imported that have the
multihost property enabled.

Without this commit, the mmp thread does not wake up and detect the new
interval until after it has waited the old multihost interval time.  A
user monitoring mmp writes via the provided kstat would be led to
believe that the changed setting did not work.

Added a test in the ZTS under mmp to verify the new functionality is
working.

Added a test to ztest which starts and stops mmp threads, and calls into
the code to signal sleeping mmp threads, to test for deadlocks or
similar locking issues.

Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
@ofaaland ofaaland force-pushed the b_multihost_interval_cb branch from 46785a7 to ca31452 Compare July 22, 2017 14:04
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jul 24, 2017
@ofaaland @behlendorf
Add callback for zfs_multihost_interval
8b3f4e2 
Add a callback to wake all running mmp threads when
zfs_multihost_interval is changed.

This is necessary when the interval is changed from a very large value
to a significantly lower one, while pools are imported that have the
multihost property enabled.

Without this commit, the mmp thread does not wake up and detect the new
interval until after it has waited the old multihost interval time.  A
user monitoring mmp writes via the provided kstat would be led to
believe that the changed setting did not work.

Added a test in the ZTS under mmp to verify the new functionality is
working.

Added a test to ztest which starts and stops mmp threads, and calls into
the code to signal sleeping mmp threads, to test for deadlocks or
similar locking issues.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Closes openzfs#6387
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jul 25, 2017
@ofaaland @behlendorf
Add callback for zfs_multihost_interval
4f637df 
Add a callback to wake all running mmp threads when
zfs_multihost_interval is changed.

This is necessary when the interval is changed from a very large value
to a significantly lower one, while pools are imported that have the
multihost property enabled.

Without this commit, the mmp thread does not wake up and detect the new
interval until after it has waited the old multihost interval time.  A
user monitoring mmp writes via the provided kstat would be led to
believe that the changed setting did not work.

Added a test in the ZTS under mmp to verify the new functionality is
working.

Added a test to ztest which starts and stops mmp threads, and calls into
the code to signal sleeping mmp threads, to test for deadlocks or
similar locking issues.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Closes openzfs#6387
@ofaaland
Copy link
Contributor Author

Supersed by #6397

@ofaaland ofaaland closed this Jul 25, 2017
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jul 25, 2017
@ofaaland @behlendorf
Add callback for zfs_multihost_interval
10e06f1 
Add a callback to wake all running mmp threads when
zfs_multihost_interval is changed.

This is necessary when the interval is changed from a very large value
to a significantly lower one, while pools are imported that have the
multihost property enabled.

Without this commit, the mmp thread does not wake up and detect the new
interval until after it has waited the old multihost interval time.  A
user monitoring mmp writes via the provided kstat would be led to
believe that the changed setting did not work.

Added a test in the ZTS under mmp to verify the new functionality is
working.

Added a test to ztest which starts and stops mmp threads, and calls into
the code to signal sleeping mmp threads, to test for deadlocks or
similar locking issues.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Closes openzfs#6387
behlendorf pushed a commit that referenced this pull request Jul 25, 2017
@ofaaland @behlendorf
Add callback for zfs_multihost_interval
0582e40 
Add a callback to wake all running mmp threads when
zfs_multihost_interval is changed.

This is necessary when the interval is changed from a very large value
to a significantly lower one, while pools are imported that have the
multihost property enabled.

Without this commit, the mmp thread does not wake up and detect the new
interval until after it has waited the old multihost interval time.  A
user monitoring mmp writes via the provided kstat would be led to
believe that the changed setting did not work.

Added a test in the ZTS under mmp to verify the new functionality is
working.

Added a test to ztest which starts and stops mmp threads, and calls into
the code to signal sleeping mmp threads, to test for deadlocks or
similar locking issues.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Closes #6387
@ofaaland ofaaland deleted the b_multihost_interval_cb branch September 19, 2017 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ofaaland