Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NULL pointer when O_SYNC read in snapshot #6494

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Fix NULL pointer when O_SYNC read in snapshot #6494

merged 1 commit into from
Aug 11, 2017

Conversation

tuxoko
Copy link
Contributor

@tuxoko tuxoko commented Aug 10, 2017

When doing read on a file open with O_SYNC, it will trigger zil_commit.
However for snapshot, there's no zil, so we shouldn't be doing that.

Signed-off-by: Chunwei Chen david.chen@osnexus.com

Description

Motivation and Context

#6478

How Has This Been Tested?

Test by open file in snapshot with O_SYNC and read(2).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

Fix NULL pointer when O_SYNC read in snapshot
533c9d3 
When doing read on a file open with O_SYNC, it will trigger zil_commit.
However for snapshot, there's no zil, so we shouldn't be doing that.

Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
behlendorf
behlendorf approved these changes Aug 10, 2017
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's amazing this went unnoticed until now.

@behlendorf behlendorf merged commit 3769948 into openzfs:master Aug 11, 2017
tonyhutter pushed a commit that referenced this pull request Aug 22, 2017
@tuxoko @tonyhutter
Fix NULL pointer when O_SYNC read in snapshot
aec4318 
When doing read on a file open with O_SYNC, it will trigger zil_commit.
However for snapshot, there's no zil, so we shouldn't be doing that.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes #6478 
Closes #6494
Fabian-Gruenbichler pushed a commit to Fabian-Gruenbichler/zfs that referenced this pull request Sep 29, 2017
@tuxoko @Fabian-Gruenbichler
Fix NULL pointer when O_SYNC read in snapshot
cfbf6f6 
When doing read on a file open with O_SYNC, it will trigger zil_commit.
However for snapshot, there's no zil, so we shouldn't be doing that.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes openzfs#6478 
Closes openzfs#6494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuxoko @behlendorf @gmelikov