Allow pool names that are not reserved but only start with reserved #7208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpool(8) says "The pool names mirror, raidz, spare and log are reserved,", but the command actually avoids entire patterns which start with "mirror"/"raidz"/"spare" by using strncmp(3) without terminating null considered. It does right for "log" by not using strncmp(3) with size of 3 (should be 4 or strcmp(3)). (or fix zpool(8) man page if this is really intended behavior.) -- e.g. zpool(8) avoids "spare<something>". # zpool create spareribs /dev/sdb cannot create 'spareribs': name is reserved pool name may have been omitted Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
Codecov Report
@@ Coverage Diff @@
## master #7208 +/- ##
==========================================
- Coverage 76.43% 76.2% -0.24%
==========================================
Files 327 327
Lines 103785 103785
==========================================
- Hits 79333 79093 -240
- Misses 24452 24692 +240
Continue to review full report at Codecov.
|
|
@kusumi rather than allow these pool names let's update the documentation accordingly. While we could fix this with your patch, my concern is that if we were to do so then it would be possible to unwitingly create pools on Linux which wouldn't work properly on the other OpenZFS platforms. |
kusumi
added a commit
to kusumi/zfs
that referenced
this pull request
Feb 22, 2018
PR openzfs#7208 was originally a patch to allow pool names which begin with mirror,raidz,spare (but do not equal), however we rather document it in the man page for compatibility with other OpenZFS implementations, i.e. avoid pool names that may not work on non-Linux platforms. Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com> Closes openzfs#7208
kusumi
added a commit
to kusumi/zfs
that referenced
this pull request
Feb 22, 2018
PR openzfs#7208 was a patch to allow non-reserved pool names which begin with mirror,raidz,spare (but do not equal), however we rather document it in the man page for compatibility with other OpenZFS implementations, i.e. avoid pool names that may not work on non-Linux platforms. Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com> Closes openzfs#7208
13 tasks
|
Sure. I have created #7216. |
behlendorf
pushed a commit
that referenced
this pull request
Mar 9, 2018
PR #7208 was a patch to allow non-reserved pool names which begin with mirror, raidz, spare (but do not equal), however we'd rather document it in the man page for compatibility with other OpenZFS implementations, to avoid pool names that may not work on non-Linux platforms. Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com> Closes #7216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zpool(8) says "The pool names mirror, raidz, spare and log are
reserved,", but the command actually avoids entire patterns which
start with "mirror"/"raidz"/"spare" by using strncmp(3) without
terminating null considered. It does right for "log" by not using
strncmp(3) with size of 3 (should be 4 or strcmp(3)).
(or fix zpool(8) man page if this is really intended behavior.)
e.g. zpool(8) avoids "spare<something>".
# zpool create spareribs /dev/sdb
cannot create 'spareribs': name is reserved
pool name may have been omitted
Description
Fixes zpool_name_valid() used for sanity checks of zpool name.
strncmp(3) size should contain termination null string.
Motivation and Context
Allow pool names that are not reserved but only start with reserved names.
How Has This Been Tested?
By running for e.g. zpool create command.
Types of changes
Checklist:
Signed-off-by.