Linux 5.2 compat: Fix config/kernel-shrink.m4 test failure #8776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8776 +/- ##
==========================================
- Coverage 78.75% 78.71% -0.04%
==========================================
Files 382 382
Lines 117809 117809
==========================================
- Hits 92776 92730 -46
- Misses 25033 25079 +46
Continue to review full report at Codecov.
|
behlendorf
approved these changes
May 23, 2019
behlendorf
added
the
Type: Building
|
I'm not sure, but there looks to be change(s) in kbuild in 5.2, e.g. torvalds/linux@83da1be. |
loli10K
approved these changes
May 25, 2019
"whether ->count_objects callback exists" test failed with "error: error" message for using an incomplete function shrinker_cb(). This is caused by torvalds/linux@83da1bed86. It's configurable, but we would want to be able to compile with default kbuild setting. Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
|
This was caused by torvalds/linux@83da1be. Definition of KBUILD_MODPOST_WARN is as follows. |
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Jun 7, 2019
"whether ->count_objects callback exists" test failed with "error: error" message for using an incomplete function shrinker_cb(). This is caused by torvalds/linux@83da1bed86. It's configurable, but we would want to be able to compile with default kbuild setting. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: loli10K <ezomori.nozomu@gmail.com> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com> Closes #8776
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 7, 2019
"whether ->count_objects callback exists" test failed with "error: error" message for using an incomplete function shrinker_cb(). This is caused by torvalds/linux@83da1bed86. It's configurable, but we would want to be able to compile with default kbuild setting. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: loli10K <ezomori.nozomu@gmail.com> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com> Closes openzfs#8776
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 15, 2019
"whether ->count_objects callback exists" test failed with "error: error" message for using an incomplete function shrinker_cb(). This is caused by torvalds/linux@83da1bed86. It's configurable, but we would want to be able to compile with default kbuild setting. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: loli10K <ezomori.nozomu@gmail.com> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com> Closes openzfs#8776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix ./configure failure on 5.2-rc1.
Note that ZoL still doesn't compile on 5.2 due to several other kernel side changes.
Description
whether ->count_objects callback existstest failed witherror: errormessage (at AC_MSG_ERROR(error)) for usingan incomplete function shrinker_cb().
Confirmed on Fedora 29 with 5.2-rc1 (but not 5.1 with same gcc).
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.