Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zpool: trim -p is not a valid option #8781

Merged
merged 1 commit into from
May 24, 2019
Merged

zpool: trim -p is not a valid option #8781

merged 1 commit into from
May 24, 2019

Conversation

loli10K
Copy link
Contributor

@loli10K loli10K commented May 21, 2019

Motivation and Context

zpool help message shows a -p option:

root@linux:~# zpool trim
missing pool name argument
usage:
	trim [-dp] [-r <rate>] [-c | -s] <pool> [<device> ...]
root@linux:~# zpool trim -p rpool
invalid option 'p'
usage:
	trim [-dp] [-r <rate>] [-c | -s] <pool> [<device> ...]
root@linux:~#

Description

This commit removes the documented but not handled "-p" option from zpool(8) help message.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@loli10K
zpool: trim -p is not a valid option
263b4ea 
This commit removes the documented but not handled "-p" option from
zpool(8) help message.

Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
@loli10K loli10K added the Status: Code Review Needed Ready for review and testing label May 21, 2019
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #8781 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8781      +/-   ##
==========================================
+ Coverage   78.63%    78.7%   +0.06%     
==========================================
  Files         381      381              
  Lines      117798   117797       -1     
==========================================
+ Hits        92636    92707      +71     
+ Misses      25162    25090      -72
Flag Coverage Δ
#kernel 79.3% <ø> (-0.03%) ⬇️
#user 67.2% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc41a7...263b4ea. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 24, 2019
@behlendorf behlendorf merged commit e55db32 into openzfs:master May 24, 2019
behlendorf pushed a commit that referenced this pull request Jun 7, 2019
@loli10K @behlendorf
zpool: trim -p is not a valid option
abe267f 
This commit removes the documented but not handled "-p" option from
zpool(8) help message.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #8781
allanjude pushed a commit to allanjude/zfs that referenced this pull request Jun 7, 2019
@loli10K @allanjude
zpool: trim -p is not a valid option
cc75dc9 
This commit removes the documented but not handled "-p" option from
zpool(8) help message.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#8781
allanjude pushed a commit to allanjude/zfs that referenced this pull request Jun 15, 2019
@loli10K @allanjude
zpool: trim -p is not a valid option
8becfbe 
This commit removes the documented but not handled "-p" option from
zpool(8) help message.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#8781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@chrisrd chrisrd chrisrd approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loli10K @behlendorf @chrisrd @gmelikov