Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zpool: status -t is not documented in help message #8782

Merged
merged 1 commit into from
May 24, 2019

Conversation

loli10K
Copy link
Contributor

@loli10K loli10K commented May 21, 2019

Motivation and Context

zpool status -t is not documented in the help message:

root@linux:~# zpool status -h
invalid option 'h'
usage:
	status [-c [script1,script2,...]] [-igLpPsvxD]  [-T d|u] [pool] ... 
	    [interval [count]]
root@linux:~# zpool status -t
  pool: rpool
 state: ONLINE
  scan: none requested
config:

	NAME                        STATE     READ WRITE CKSUM
	rpool                       ONLINE       0     0     0
	  /var/tmp/zpool_rpool.dat  ONLINE       0     0     0  (untrimmed)

errors: No known data errors
root@linux:~# 

Description

This commit adds the undocumented "-t" option to zpool(8) help message.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

This commit adds the undocumented "-t" option to zpool(8) help message.

Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
@loli10K loli10K added the Status: Code Review Needed Ready for review and testing label May 21, 2019
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #8782 into master will decrease coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #8782     +/-   ##
=========================================
- Coverage   78.63%   78.24%   -0.4%     
=========================================
  Files         381      372      -9     
  Lines      117798   117412    -386     
=========================================
- Hits        92636    91864    -772     
- Misses      25162    25548    +386
Flag Coverage Δ
#kernel 78.2% <ø> (-1.14%) ⬇️
#user 67.58% <ø> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc41a7...0d67cc6. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 24, 2019
@behlendorf behlendorf merged commit 4397794 into openzfs:master May 24, 2019
behlendorf pushed a commit that referenced this pull request Jun 7, 2019
This commit adds the undocumented "-t" option to zpool(8) help message.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #8782
allanjude pushed a commit to allanjude/zfs that referenced this pull request Jun 7, 2019
This commit adds the undocumented "-t" option to zpool(8) help message.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#8782
allanjude pushed a commit to allanjude/zfs that referenced this pull request Jun 15, 2019
This commit adds the undocumented "-t" option to zpool(8) help message.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#8782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants