zfs: don't pretty-print objsetid property #8784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The objsetid property, while being stored as a number, is a dataset identifier and should not be pretty-printed. Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8784 +/- ##
==========================================
- Coverage 78.63% 78.55% -0.09%
==========================================
Files 381 381
Lines 117798 117797 -1
==========================================
- Hits 92636 92530 -106
- Misses 25162 25267 +105
Continue to review full report at Codecov.
|
chrisrd
approved these changes
May 22, 2019
gmelikov
approved these changes
May 22, 2019
behlendorf
approved these changes
May 24, 2019
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Jun 7, 2019
The objsetid property, while being stored as a number, is a dataset identifier and should not be pretty-printed. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Chris Dunlop <chris@onthe.net.au> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes #8784
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 7, 2019
The objsetid property, while being stored as a number, is a dataset identifier and should not be pretty-printed. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Chris Dunlop <chris@onthe.net.au> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#8784
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 15, 2019
The objsetid property, while being stored as a number, is a dataset identifier and should not be pretty-printed. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Chris Dunlop <chris@onthe.net.au> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#8784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The objsetid property, while being stored as a number, is a dataset identifier and should not be pretty-printed.
Description
Change default print format of objsetid property.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.