-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfs-tests: fix warnings when packaging some .shlib files #8787
Merged
behlendorf
merged 1 commit into
openzfs:master
from
loli10K:update_style_check_zfstests
May 24, 2019
Merged
zfs-tests: fix warnings when packaging some .shlib files #8787
behlendorf
merged 1 commit into
openzfs:master
from
loli10K:update_style_check_zfstests
May 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents the following warning when packaging some zfs-tests files: *** WARNING: ./usr/src/zfs-0.8.0/tests/zfs-tests/include/zpool_script.shlib is executable but has empty or no shebang, removing executable bit Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
jwk404
approved these changes
May 21, 2019
dinatale2
approved these changes
May 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #8787 +/- ##
==========================================
+ Coverage 78.63% 78.81% +0.17%
==========================================
Files 381 381
Lines 117798 117797 -1
==========================================
+ Hits 92636 92842 +206
+ Misses 25162 24955 -207
Continue to review full report at Codecov.
|
gmelikov
approved these changes
May 22, 2019
behlendorf
approved these changes
May 24, 2019
behlendorf
pushed a commit
that referenced
this pull request
Jun 7, 2019
This change prevents the following warning when packaging some zfs-tests files: *** WARNING: ./usr/src/zfs-0.8.0/tests/zfs-tests/include/zpool_script.shlib is executable but has empty or no shebang, removing executable bit Reviewed by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <guss80@gmail.com> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes #8787
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 7, 2019
This change prevents the following warning when packaging some zfs-tests files: *** WARNING: ./usr/src/zfs-0.8.0/tests/zfs-tests/include/zpool_script.shlib is executable but has empty or no shebang, removing executable bit Reviewed by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <guss80@gmail.com> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#8787
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 15, 2019
This change prevents the following warning when packaging some zfs-tests files: *** WARNING: ./usr/src/zfs-0.8.0/tests/zfs-tests/include/zpool_script.shlib is executable but has empty or no shebang, removing executable bit Reviewed by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <guss80@gmail.com> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#8787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change should prevent the following warning when packaging some zfs-tests files:
Description
Update Makefile to verify more files in
testscheck
make targetHow Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.