Double-free of encryption wrapping key due to invalid pool properties #8791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits fixes a double-free in zfs_ioc_pool_create() triggered by specifying an unsupported combination of properties when creating a pool with encryption enabled. Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8791 +/- ##
==========================================
+ Coverage 78.63% 78.79% +0.15%
==========================================
Files 381 381
Lines 117798 117791 -7
==========================================
+ Hits 92636 92812 +176
+ Misses 25162 24979 -183
Continue to review full report at Codecov.
|
behlendorf
approved these changes
May 24, 2019
tcaputi
approved these changes
May 24, 2019
| (void) spa_destroy(spa_name); | ||
| unload_wkey = B_FALSE; /* spa_destroy() unloads wrapping keys */ |
There was a problem hiding this comment.
Personally, I would move this up just beneath spa_create(). The issue here is that after spa_create() runs (without error), it "owns" the dsl crypto key so we should set this variable as soon as that is true (to prevent future problems). This code is equivalent though.
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Jun 7, 2019
This commits fixes a double-free in zfs_ioc_pool_create() triggered by specifying an unsupported combination of properties when creating a pool with encryption enabled. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tom Caputi <tcaputi@datto.com> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes #8791
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 7, 2019
This commits fixes a double-free in zfs_ioc_pool_create() triggered by specifying an unsupported combination of properties when creating a pool with encryption enabled. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tom Caputi <tcaputi@datto.com> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#8791
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Jun 15, 2019
This commits fixes a double-free in zfs_ioc_pool_create() triggered by specifying an unsupported combination of properties when creating a pool with encryption enabled. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tom Caputi <tcaputi@datto.com> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes openzfs#8791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This commits fixes a double-free in zfs_ioc_pool_create() triggered by specifying an unsupported combination of properties when creating a pool with encryption enabled.
Description
How Has This Been Tested?
Tested on a Debian with updated test case
Types of changes
Checklist:
Signed-off-by.