Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grammar: it is #8818

Merged
merged 1 commit into from
May 28, 2019
Merged

grammar: it is #8818

merged 1 commit into from
May 28, 2019

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 26, 2019

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@jsoref
grammar: it is / plural agreement
946fde9 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 26, 2019 •
edited
Loading

Codecov Report

Merging #8818 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8818      +/-   ##
==========================================
+ Coverage   78.73%   78.82%   +0.08%     
==========================================
  Files         382      382              
  Lines      117812   117812              
==========================================
+ Hits        92758    92860     +102     
+ Misses      25054    24952     -102
Flag Coverage Δ
#kernel 79.4% <ø> (+0.06%) ⬆️
#user 67.84% <ø> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841a7a9...946fde9. Read the comment docs.

chrisrd
chrisrd suggested changes May 27, 2019
View reviewed changes
Copy link
Contributor

@chrisrd chrisrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst you're there, "it's a" is singular, but the following "ZFS filesystems" is plural...

@ahrens ahrens added the Type: Documentation Indicates a requested change to the documentation label May 27, 2019
rlaager
rlaager reviewed May 27, 2019
View reviewed changes
Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if "filesystems" is changed to "filesystem".

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label May 28, 2019
@behlendorf behlendorf merged commit 46df7e6 into openzfs:master May 28, 2019
@jsoref jsoref deleted the grammar-it-is branch May 28, 2019 23:09
allanjude pushed a commit to allanjude/zfs that referenced this pull request Jun 7, 2019
@jsoref @allanjude
grammar: it is / plural agreement
ad380f8 
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Closes openzfs#8818
allanjude pushed a commit to allanjude/zfs that referenced this pull request Jun 15, 2019
@jsoref @allanjude
grammar: it is / plural agreement
882de71 
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Closes openzfs#8818
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@jsoref @tonyhutter
grammar: it is / plural agreement
0dab99c 
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Closes openzfs#8818
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@jsoref @tonyhutter
grammar: it is / plural agreement
cd2236d 
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Closes openzfs#8818
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@jsoref @tonyhutter
grammar: it is / plural agreement
2cab4d7 
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Closes openzfs#8818
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@jsoref @tonyhutter
grammar: it is / plural agreement
3e99cbe 
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Closes openzfs#8818
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@jsoref @tonyhutter
grammar: it is / plural agreement
5217ace 
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Closes openzfs#8818
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@jsoref @tonyhutter
grammar: it is / plural agreement
6ce10fd 
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Closes #8818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlaager rlaager rlaager left review comments

@chrisrd chrisrd chrisrd approved these changes

@ahrens ahrens ahrens approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Documentation Indicates a requested change to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsoref @rlaager @ahrens @chrisrd @behlendorf