Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

l2arc_apply_transforms: Fix typo in comment #8822

Merged
merged 1 commit into from
Jun 6, 2019
Merged

l2arc_apply_transforms: Fix typo in comment #8822

merged 1 commit into from
Jun 6, 2019

Conversation

allanjude
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ahrens ahrens added the Type: Documentation Indicates a requested change to the documentation label May 27, 2019
rlaager
rlaager suggested changes May 27, 2019
View reviewed changes
Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in “eliminate” too. (Sorry for the duplicate notification. I am converting my comment, from mobile, into a real review.)

@behlendorf behlendorf added the Status: Revision Needed Changes are required for the PR to be accepted label May 28, 2019
@behlendorf
Copy link
Contributor

@allanjude when you get a moment it would be great if you could refresh this to address @rlaager's comment.

@rlaager
Copy link
Member

rlaager commented Jun 5, 2019

@behlendorf In fairness, could you just fix it as you merge (in one commit or two)? I mean, this is pretty trivial.

@allanjude
Copy link
Contributor Author

Done

@behlendorf
Copy link
Contributor

@allanjude thanks! @rlaager you're right, and I almost did exactly that but never quite got to it. And I figured there wasn't any real rush in fixing a typo.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Revision Needed Changes are required for the PR to be accepted labels Jun 6, 2019
@behlendorf behlendorf merged commit b7109a4 into openzfs:master Jun 6, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@allanjude @tonyhutter
l2arc_apply_transforms: Fix typo in comment
47c59ad 
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Allan Jude <allanjude@freebsd.org>
Closes openzfs#8822
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@allanjude @tonyhutter
l2arc_apply_transforms: Fix typo in comment
e0967a6 
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Allan Jude <allanjude@freebsd.org>
Closes openzfs#8822
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@allanjude @tonyhutter
l2arc_apply_transforms: Fix typo in comment
73d3101 
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Allan Jude <allanjude@freebsd.org>
Closes openzfs#8822
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@allanjude @tonyhutter
l2arc_apply_transforms: Fix typo in comment
fa475cd 
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Allan Jude <allanjude@freebsd.org>
Closes openzfs#8822
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@allanjude @tonyhutter
l2arc_apply_transforms: Fix typo in comment
b8d3ed8 
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Allan Jude <allanjude@freebsd.org>
Closes openzfs#8822
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@allanjude @tonyhutter
l2arc_apply_transforms: Fix typo in comment
60cbc18 
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Allan Jude <allanjude@freebsd.org>
Closes #8822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlaager rlaager rlaager requested changes

@gmelikov gmelikov gmelikov approved these changes

@chrisrd chrisrd chrisrd approved these changes

@ahrens ahrens ahrens approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Documentation Indicates a requested change to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@allanjude @behlendorf @rlaager @ahrens @chrisrd @gmelikov