Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make zfs_async_block_max_blocks handle zero correctly #8829

Closed
wants to merge 3 commits into from

Conversation

TulsiJain
Copy link
Contributor

Motivation and Context

Fixed this issue #8289

Description

frees all data when zfs_async_black_max_blocks is set to 0.

How Has This Been Tested?

build the load in ubuntu VM. set the zfs_async_black_max_blocks to 0 and everything worked as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Signed-off-by: TulsiJain <tulsi.jain@delphix.com>
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this, just a minor style nit.

module/zfs/dsl_scan.c Outdated Show resolved Hide resolved
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 28, 2019
@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #8829 into master will decrease coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8829      +/-   ##
==========================================
- Coverage   78.99%   78.76%   -0.24%     
==========================================
  Files         382      382              
  Lines      117780   117813      +33     
==========================================
- Hits        93042    92794     -248     
- Misses      24738    25019     +281
Flag Coverage Δ
#kernel 79.21% <100%> (-0.22%) ⬇️
#user 67.3% <100%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1608985...047262e. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 30, 2019
@behlendorf behlendorf closed this in a3c98d5 Jun 3, 2019
behlendorf pushed a commit that referenced this pull request Jun 7, 2019
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: TulsiJain <tulsi.jain@delphix.com>
Closes #8829
Closes #8289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants