Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lockdep warning on insmod #8884

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Fix lockdep warning on insmod #8884

merged 1 commit into from
Jun 13, 2019

Conversation

kusumi
Copy link
Member

@kusumi kusumi commented Jun 11, 2019

Motivation and Context

#8868

Description

sysfs_attr_init() is required to make lockdep happy for dynamically
allocated sysfs attributes. This fixed #8868 on Fedora 29 running
kernel-debug.

torvalds/linux@918b8ac55b is an example of commit which fixed this.
See include/linux/sysfs.h for what it actually does.
This requirement was introduced in v2.6.34.

How Has This Been Tested?

By running it on lockdep'd kernel.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@kusumi kusumi added the Status: Code Review Needed Ready for review and testing label Jun 11, 2019
@kusumi
Fix lockdep warning on insmod
69937be 
sysfs_attr_init() is required to make lockdep happy for dynamically
allocated sysfs attributes. This fixed openzfs#8868 on Fedora 29 running
kernel-debug.

This requirement was introduced in 2.6.34.
See include/linux/sysfs.h for what it actually does.

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
@behlendorf behlendorf requested a review from tonyhutter June 11, 2019 17:13
@codecov
Copy link

codecov bot commented Jun 11, 2019 •
edited
Loading

Codecov Report

Merging #8884 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8884      +/-   ##
==========================================
+ Coverage   78.65%   78.73%   +0.07%     
==========================================
  Files         382      382              
  Lines      117791   117791              
==========================================
+ Hits        92652    92737      +85     
+ Misses      25139    25054      -85
Flag Coverage Δ
#kernel 79.29% <ø> (+0.04%) ⬆️
#user 67.15% <ø> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b873825...69937be. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jun 12, 2019
@behlendorf behlendorf requested a review from ofaaland June 12, 2019 23:47
ofaaland
ofaaland approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@ofaaland ofaaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behlendorf behlendorf merged commit daddbdc into openzfs:master Jun 13, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@kusumi @tonyhutter
Fix lockdep warning on insmod
f7274be 
sysfs_attr_init() is required to make lockdep happy for dynamically
allocated sysfs attributes. This fixed openzfs#8868 on Fedora 29 running
kernel-debug.

This requirement was introduced in 2.6.34.
See include/linux/sysfs.h for what it actually does.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#8868
Closes openzfs#8884
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@kusumi @tonyhutter
Fix lockdep warning on insmod
e084ef6 
sysfs_attr_init() is required to make lockdep happy for dynamically
allocated sysfs attributes. This fixed openzfs#8868 on Fedora 29 running
kernel-debug.

This requirement was introduced in 2.6.34.
See include/linux/sysfs.h for what it actually does.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#8868
Closes openzfs#8884
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@kusumi @tonyhutter
Fix lockdep warning on insmod
38522e2 
sysfs_attr_init() is required to make lockdep happy for dynamically
allocated sysfs attributes. This fixed openzfs#8868 on Fedora 29 running
kernel-debug.

This requirement was introduced in 2.6.34.
See include/linux/sysfs.h for what it actually does.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#8868
Closes openzfs#8884
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@kusumi @tonyhutter
Fix lockdep warning on insmod
05b7499 
sysfs_attr_init() is required to make lockdep happy for dynamically
allocated sysfs attributes. This fixed openzfs#8868 on Fedora 29 running
kernel-debug.

This requirement was introduced in 2.6.34.
See include/linux/sysfs.h for what it actually does.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#8868
Closes openzfs#8884
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@kusumi @tonyhutter
Fix lockdep warning on insmod
3ca60e4 
sysfs_attr_init() is required to make lockdep happy for dynamically
allocated sysfs attributes. This fixed openzfs#8868 on Fedora 29 running
kernel-debug.

This requirement was introduced in 2.6.34.
See include/linux/sysfs.h for what it actually does.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#8868
Closes openzfs#8884
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@kusumi @tonyhutter
Fix lockdep warning on insmod
4f809bd 
sysfs_attr_init() is required to make lockdep happy for dynamically
allocated sysfs attributes. This fixed #8868 on Fedora 29 running
kernel-debug.

This requirement was introduced in 2.6.34.
See include/linux/sysfs.h for what it actually does.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes #8868
Closes #8884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofaaland ofaaland ofaaland approved these changes

@behlendorf behlendorf behlendorf approved these changes

@tonyhutter tonyhutter Awaiting requested review from tonyhutter

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

a ton of lockdep warnings on 0.8.0 with debug-enabled rhel8 kernel
3 participants
@kusumi @behlendorf @ofaaland