lz4_decompress_abd declared but not defined #8894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lz4_decompress_abd` is declared in zio_compress.h but it is not defined anywhere. The declaration should be removed. External-issue: DLPX-47477 Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
|
This is a trivial change -- removing the unneeded prototype. Build testing is the only possible test for this ;). |
|
when i stumbled over this 2 weeks ago I had really hoped Delphix had a version of lz4 that could read ABDs and had just forgotten to upstream it. |
behlendorf
approved these changes
Jun 12, 2019
|
@allanjude if I recall correctly, that was functionality we wanted to add but haven't gotten to quite yet. |
|
FWIW, there was an ABD-aware lz4 decompress algorithm, but it was an unoptimized implementation and was much much slower than bcopy+lz4, so we abandoned it. Subsequent benchmarking has shown that the amount of performance that can be gained by avoiding the bcopy (i.e. bcopy+lz4 decompress vs just lz4 decompress) is minimal (<10% IIRC). The bcopy doesn't cost that much if you have to access the memory anyway - probably because once you bcopy, lz4 isn't touching main memory, it's getting everything from the on-CPU L3 cache. |
Codecov Report
@@ Coverage Diff @@
## master #8894 +/- ##
==========================================
+ Coverage 78.75% 78.8% +0.05%
==========================================
Files 382 382
Lines 117818 117808 -10
==========================================
+ Hits 92787 92839 +52
+ Misses 25031 24969 -62
Continue to review full report at Codecov.
|
allanjude
approved these changes
Jun 13, 2019
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 13, 2019
`lz4_decompress_abd` is declared in zio_compress.h but it is not defined anywhere. The declaration should be removed. Reviewed by: Dan Kimmel <dan.kimmel@delphix.com> Reviewed-by: Allan Jude <allanjude@freebsd.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> External-issue: DLPX-47477 Closes openzfs#8894
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 22, 2019
`lz4_decompress_abd` is declared in zio_compress.h but it is not defined anywhere. The declaration should be removed. Reviewed by: Dan Kimmel <dan.kimmel@delphix.com> Reviewed-by: Allan Jude <allanjude@freebsd.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> External-issue: DLPX-47477 Closes openzfs#8894
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 23, 2019
`lz4_decompress_abd` is declared in zio_compress.h but it is not defined anywhere. The declaration should be removed. Reviewed by: Dan Kimmel <dan.kimmel@delphix.com> Reviewed-by: Allan Jude <allanjude@freebsd.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> External-issue: DLPX-47477 Closes openzfs#8894
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 17, 2019
`lz4_decompress_abd` is declared in zio_compress.h but it is not defined anywhere. The declaration should be removed. Reviewed by: Dan Kimmel <dan.kimmel@delphix.com> Reviewed-by: Allan Jude <allanjude@freebsd.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> External-issue: DLPX-47477 Closes openzfs#8894
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 18, 2019
`lz4_decompress_abd` is declared in zio_compress.h but it is not defined anywhere. The declaration should be removed. Reviewed by: Dan Kimmel <dan.kimmel@delphix.com> Reviewed-by: Allan Jude <allanjude@freebsd.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> External-issue: DLPX-47477 Closes openzfs#8894
tonyhutter
pushed a commit
that referenced
this pull request
Sep 26, 2019
`lz4_decompress_abd` is declared in zio_compress.h but it is not defined anywhere. The declaration should be removed. Reviewed by: Dan Kimmel <dan.kimmel@delphix.com> Reviewed-by: Allan Jude <allanjude@freebsd.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> External-issue: DLPX-47477 Closes #8894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
lz4_decompress_abdis declared in zio_compress.h but it is not definedanywhere.
Description
The declaration should be removed.
External-issue: DLPX-47477
How Has This Been Tested?
compiled
Types of changes
Checklist:
Signed-off-by.