Update zfs-lib.sh.in Issue #8920 #8938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Jun 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #8938 +/- ##
==========================================
- Coverage 78.86% 78.65% -0.22%
==========================================
Files 388 388
Lines 120055 120222 +167
==========================================
- Hits 94683 94559 -124
- Misses 25372 25663 +291
Continue to review full report at Codecov.
|
ghfields
approved these changes
Jun 20, 2019
|
@dacianstremtan when you get a change, please refresh this to include your signed off by so it can be merged. |
behlendorf
added
Status: Accepted
Signed-off-by: Dacian Reece-Stremtan <dacianstremtan@gmail.com>
|
@behlendorf, I added signed off. |
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 13, 2019
The whereis command should not be used since it may not exist in the initramfs. The dracut plymouth module also uses the type command instead of whereis. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Garrett Fields <ghfields@gmail.com> Signed-off-by: Dacian Reece-Stremtan <dacianstremtan@gmail.com> Closes openzfs#8920 Closes openzfs#8938
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 22, 2019
The whereis command should not be used since it may not exist in the initramfs. The dracut plymouth module also uses the type command instead of whereis. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Garrett Fields <ghfields@gmail.com> Signed-off-by: Dacian Reece-Stremtan <dacianstremtan@gmail.com> Closes openzfs#8920 Closes openzfs#8938
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Aug 23, 2019
The whereis command should not be used since it may not exist in the initramfs. The dracut plymouth module also uses the type command instead of whereis. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Garrett Fields <ghfields@gmail.com> Signed-off-by: Dacian Reece-Stremtan <dacianstremtan@gmail.com> Closes openzfs#8920 Closes openzfs#8938
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 17, 2019
The whereis command should not be used since it may not exist in the initramfs. The dracut plymouth module also uses the type command instead of whereis. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Garrett Fields <ghfields@gmail.com> Signed-off-by: Dacian Reece-Stremtan <dacianstremtan@gmail.com> Closes openzfs#8920 Closes openzfs#8938
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 18, 2019
The whereis command should not be used since it may not exist in the initramfs. The dracut plymouth module also uses the type command instead of whereis. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Garrett Fields <ghfields@gmail.com> Signed-off-by: Dacian Reece-Stremtan <dacianstremtan@gmail.com> Closes openzfs#8920 Closes openzfs#8938
tonyhutter
pushed a commit
that referenced
this pull request
Sep 26, 2019
The whereis command should not be used since it may not exist in the initramfs. The dracut plymouth module also uses the type command instead of whereis. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Garrett Fields <ghfields@gmail.com> Signed-off-by: Dacian Reece-Stremtan <dacianstremtan@gmail.com> Closes #8920 Closes #8938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace whereis with type in zfs-lib.sh
Motivation and Context
Fix for issue #8920
Description
How Has This Been Tested?
Installed it on my CentOS installation.
CentOS 7.6
Types of changes
Checklist:
Signed-off-by.