Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor style cleanup #9030

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Minor style cleanup #9030

merged 1 commit into from
Jul 17, 2019

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Keep the code base consistent and clean.

Description

Resolve an assortment of style inconsistencies including
use of white space, typos, capitaliztion, and line wrapping.
There is no functional change.

How Has This Been Tested?

Compiled and manually inspected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
Minor style cleanup
2b77e6b 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitaliztion, and line wrapping.
There is no functional change.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 12, 2019
@codecov
Copy link

codecov bot commented Jul 13, 2019 •
edited
Loading

Codecov Report

Merging #9030 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9030      +/-   ##
==========================================
+ Coverage   78.62%   78.65%   +0.03%     
==========================================
  Files         401      401              
  Lines      120158   120158              
==========================================
+ Hits        94476    94514      +38     
+ Misses      25682    25644      -38
Flag Coverage Δ
#kernel 79.41% <100%> (ø) ⬆️
#user 66.57% <100%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5db313...2b77e6b. Read the comment docs.

@behlendorf behlendorf requested a review from tonyhutter July 16, 2019 18:19
tonyhutter
tonyhutter approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@tonyhutter tonyhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanups

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 17, 2019
@behlendorf behlendorf merged commit 8062b76 into openzfs:master Jul 17, 2019
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
@behlendorf
Minor style cleanup
92f260b 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitalization, and line wrapping.
There is no functional change.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9030
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
@behlendorf
Minor style cleanup
80e17cd 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitalization, and line wrapping.
There is no functional change.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9030
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
@behlendorf @tonyhutter
Minor style cleanup
f8e365a 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitalization, and line wrapping.
There is no functional change.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9030
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 21, 2019
@behlendorf @tonyhutter
Minor style cleanup
a2adc0f 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitalization, and line wrapping.
There is no functional change.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9030
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
@behlendorf @tonyhutter
Minor style cleanup
61ad5d9 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitalization, and line wrapping.
There is no functional change.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9030
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
@behlendorf @tonyhutter
Minor style cleanup
6f8db71 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitalization, and line wrapping.
There is no functional change.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9030
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
@behlendorf @tonyhutter
Minor style cleanup
116b3fe 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitalization, and line wrapping.
There is no functional change.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9030
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
@behlendorf @tonyhutter
Minor style cleanup
0399c36 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitalization, and line wrapping.
There is no functional change.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9030
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 23, 2019
@behlendorf @tonyhutter
Minor style cleanup
67e210d 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitalization, and line wrapping.
There is no functional change.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9030
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
@behlendorf @tonyhutter
Minor style cleanup
984bfb3 
Resolve an assortment of style inconsistencies including
use of white space, typos, capitalization, and line wrapping.
There is no functional change.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #9030
@behlendorf behlendorf deleted the style-fixes branch April 19, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @gmelikov @tonyhutter