Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module_param() type for zfs_read_chunk_size #9051

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

kusumi
Copy link
Member

@kusumi kusumi commented Jul 17, 2019

Motivation and Context

Description

zfs_read_chunk_size is unsigned long.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #9051 into master will increase coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9051      +/-   ##
==========================================
+ Coverage    77.6%    78.7%   +1.09%     
==========================================
  Files         391      402      +11     
  Lines      120531   121004     +473     
==========================================
+ Hits        93544    95238    +1694     
+ Misses      26987    25766    -1221
Flag Coverage Δ
#kernel 79.58% <ø> (+2.22%) ⬆️
#user 66.31% <ø> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8062b76...731f440. Read the comment docs.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 17, 2019
@behlendorf
Copy link
Contributor

Thanks, just a minor style issue. Let's wrap the entire export block with BEGIN/END CSTYLED as we've done elsewhere.

http://build.zfsonlinux.org/builders/Ubuntu%2017.10%20x86_64%20%28STYLE%29/builds/15512/steps/shell_2/logs/stdio

It's unsigned long.

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
@kusumi
Copy link
Member Author

kusumi commented Jul 17, 2019

Let's wrap the entire export block with BEGIN/END CSTYLED

Updated. It looks like this now, and make cstyle passes at least.

-/* CSTYLED */
+/* BEGIN CSTYLED */
 module_param(zfs_delete_blocks, ulong, 0644);
 MODULE_PARM_DESC(zfs_delete_blocks, "Delete files larger than N blocks async");
-module_param(zfs_read_chunk_size, long, 0644);
+module_param(zfs_read_chunk_size, ulong, 0644);
 MODULE_PARM_DESC(zfs_read_chunk_size, "Bytes to read per chunk");
+/* END CSTYLED */

@behlendorf behlendorf requested a review from tonyhutter July 18, 2019 00:38
@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #9051 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9051      +/-   ##
==========================================
+ Coverage   78.66%   78.71%   +0.05%     
==========================================
  Files         402      402              
  Lines      121005   121004       -1     
==========================================
+ Hits        95185    95245      +60     
+ Misses      25820    25759      -61
Flag Coverage Δ
#kernel 79.58% <ø> (+0.01%) ⬆️
#user 66.09% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5784c7c...c294ec2. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 19, 2019
@behlendorf behlendorf merged commit 09276fd into openzfs:master Jul 19, 2019
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
zfs_read_chunk_size is unsigned long.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9051
TulsiJain pushed a commit to TulsiJain/zfs that referenced this pull request Jul 20, 2019
zfs_read_chunk_size is unsigned long.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9051
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 13, 2019
zfs_read_chunk_size is unsigned long.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9051
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 21, 2019
zfs_read_chunk_size is unsigned long.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9051
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 22, 2019
zfs_read_chunk_size is unsigned long.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9051
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2019
zfs_read_chunk_size is unsigned long.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9051
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 17, 2019
zfs_read_chunk_size is unsigned long.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9051
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
zfs_read_chunk_size is unsigned long.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9051
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 23, 2019
zfs_read_chunk_size is unsigned long.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes openzfs#9051
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
zfs_read_chunk_size is unsigned long.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes #9051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants