Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs-mount-genrator: dependencies should be space-separated #9174

Merged
merged 1 commit into from
Aug 23, 2019
Merged

zfs-mount-genrator: dependencies should be space-separated #9174

merged 1 commit into from
Aug 23, 2019

Conversation

yshui
Copy link
Contributor

@yshui yshui commented Aug 18, 2019

Motivation and Context

zfs-mount-generator generates systemd unit for mounting zfs datasets. when the dataset is encrypted, it will generate a dependencies (Wants= and After= in systemd terms) to the corresponding load-key service

however, the generated string uses comma (,) as the separate of systemd units, while systemd actually expects spaces ( ). this cause the load-key service to not be run, and the dataset will fail to mount because it cannot be opened.

Description

when generating Wants= and Afters= strings, change the separate from comma to space.

How Has This Been Tested?

tested locally with encrypted datasets.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 21, 2019
@openzfs openzfs deleted a comment from codecov bot Aug 21, 2019
@openzfs openzfs deleted a comment from codecov bot Aug 21, 2019
@behlendorf behlendorf requested a review from rlaager August 21, 2019 22:33
@behlendorf
Copy link
Contributor

@aerusso would you mind reviewing this.

@aerusso
Copy link
Contributor

aerusso commented Aug 22, 2019

We can just jump straight to the "6th stage of debugging": "How did that ever work?" LGTM

Copy link
Member

@rlaager rlaager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is correct. Wants= is a space-separated list.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 22, 2019
@behlendorf behlendorf merged commit 19d61d6 into openzfs:master Aug 23, 2019
@aerusso aerusso mentioned this pull request Aug 25, 2019
12 tasks
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 18, 2019
Reviewed-by: Antonio Russo <antonio.e.russo@gmail.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Closes openzfs#9174
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 23, 2019
Reviewed-by: Antonio Russo <antonio.e.russo@gmail.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Closes openzfs#9174
tonyhutter pushed a commit that referenced this pull request Sep 26, 2019
Reviewed-by: Antonio Russo <antonio.e.russo@gmail.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Closes #9174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants