zfs-mount-genrator: dependencies should be space-separated #9174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
zfs-mount-generator generates systemd unit for mounting zfs datasets. when the dataset is encrypted, it will generate a dependencies (
Wants=
andAfter=
in systemd terms) to the corresponding load-key servicehowever, the generated string uses comma (,) as the separate of systemd units, while systemd actually expects spaces ( ). this cause the load-key service to not be run, and the dataset will fail to mount because it cannot be opened.
Description
when generating
Wants=
andAfters=
strings, change the separate from comma to space.How Has This Been Tested?
tested locally with encrypted datasets.
Types of changes
Checklist:
Signed-off-by
.