ZTS: Use compatible arg order in tests #9228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSD getopt() and getopt_long() want options before arguments. Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
ikozhukhov
approved these changes
Aug 28, 2019
behlendorf
approved these changes
Aug 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #9228 +/- ##
==========================================
- Coverage 79.13% 72.62% -6.52%
==========================================
Files 400 371 -29
Lines 122027 119441 -2586
==========================================
- Hits 96565 86741 -9824
- Misses 25462 32700 +7238
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
ghost
deleted the
ikozhukhov
pushed a commit
to ikozhukhov/zfs
that referenced
this pull request
Aug 30, 2019
BSD getopt() and getopt_long() want options before arguments. Reorder arguments to zfs/zpool in tests to put all the options first. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@ixsystems.com> Closes openzfs#9228 Signed-off-by: Igor Kozhukhov <igor@dilos.org>
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 24, 2019
BSD getopt() and getopt_long() want options before arguments. Reorder arguments to zfs/zpool in tests to put all the options first. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@ixsystems.com> Closes openzfs#9228
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
BSD getopt() and getopt_long() want options before arguments. Reorder arguments to zfs/zpool in tests to put all the options first. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@ixsystems.com> Closes openzfs#9228
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
BSD getopt() and getopt_long() want options before arguments. Reorder arguments to zfs/zpool in tests to put all the options first. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@ixsystems.com> Closes #9228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some implementations (BSD) of getopt() and getopt_long() want options before arguments.
Description
Reorder arguments to zfs/zpool in tests to put all the options first.
How Has This Been Tested?
This has been tested by running the affected tests.
Types of changes
Checklist:
Signed-off-by.