Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in module/zfs/ #9240

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Fix typos in module/zfs/ #9240

merged 1 commit into from
Sep 3, 2019

Conversation

Gelma
Copy link
Contributor

@Gelma Gelma commented Aug 29, 2019

No description provided.

module/zfs/metaslab.c Outdated Show resolved Hide resolved
Copy link
Member

@ahrens ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I was surprised by the amount of typos that have crept in over the years. Out of curiosity, how did you find all of these? Did you use a spelling/grammar checker on the comments?

@Gelma
Copy link
Contributor Author

Gelma commented Aug 29, 2019

Thanks for doing this! I was surprised by the amount of typos that have crept in over the years. Out of curiosity, how did you find all of these? Did you use a spelling/grammar checker on the comments?

I have stupid/messy Python and Bash scripts I wrote in the last five years. They run machine learning, deep mind, IA... no, no, they are made of stupid mix of regex, black/white list, some tricks (if a word appears just one time, probably it's a typo, or a not used variable/include, and so on).

I take note of already seen typos, because we usually repeat our mistakes, parsing git logs of projects on github (another stupid script), or from what I already fixed.

All of these (via PostgreSQL and so on) generates a few output, very easy to read and check (for me), with colors and so on.

I usually give back to community my dict (look at Codespell for example; I send them all my fixed typos of LibreOffice and project I follow/use).
The code is really messy and keep changing. At the moment having it up and running on something else than my laptop is a nightmare. When it will be really user friendly, I'm going to GPL'ed.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 29, 2019
module/zfs/zio.c Outdated Show resolved Hide resolved
module/zfs/zio_crypt.c Outdated Show resolved Hide resolved
Thanks a lot for patch review to @freqlabs

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 3, 2019
@behlendorf behlendorf merged commit e1cfd73 into openzfs:master Sep 3, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 24, 2019
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Closes openzfs#9240
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Closes openzfs#9240
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Closes #9240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants