9185 metaslab_verify_weight_and_frag() shouldn't cause side-effects #9282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`metaslab_verify_weight_and_frag()` a verification function and by the end of it there shouldn't be any side-effects. The function calls `metaslab_weight()` which in turn calls `metaslab_set_fragmentation()`. The latter can dirty and otherwise not dirty metaslab fro the next TXGand set `metaslab_condense_wanted` if the spacemaps were just upgraded (meaning we just enabled the SPACEMAP_HISTOGRAM feature through upgrade). This patch adds a new flag as a parameter to `metaslab_weight()` and `metaslab_set_fragmentation()` making the dirtying of the metaslab optional. Signed-off-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Codecov Report
@@ Coverage Diff @@
## master #9282 +/- ##
==========================================
- Coverage 79% 67.2% -11.8%
==========================================
Files 400 325 -75
Lines 122041 104687 -17354
==========================================
- Hits 96416 70359 -26057
- Misses 25625 34328 +8703
Continue to review full report at Codecov.
|
ahrens
approved these changes
Sep 4, 2019
behlendorf
approved these changes
Sep 4, 2019
behlendorf
added
Status: Accepted
allanjude
pushed a commit
to KlaraSystems/zfs
that referenced
this pull request
Apr 28, 2020
`metaslab_verify_weight_and_frag()` a verification function and by the end of it there shouldn't be any side-effects. The function calls `metaslab_weight()` which in turn calls `metaslab_set_fragmentation()`. The latter can dirty and otherwise not dirty metaslab fro the next TXGand set `metaslab_condense_wanted` if the spacemaps were just upgraded (meaning we just enabled the SPACEMAP_HISTOGRAM feature through upgrade). This patch adds a new flag as a parameter to `metaslab_weight()` and `metaslab_set_fragmentation()` making the dirtying of the metaslab optional. Reviewed-by: Matt Ahrens <matt@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Serapheim Dimitropoulos <serapheim@delphix.com> Closes openzfs#9185 Closes openzfs#9282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metaslab_verify_weight_and_frag()a verification function andby the end of it there shouldn't be any side-effects.
The function calls
metaslab_weight()which in turn callsmetaslab_set_fragmentation(). The latter can dirty and otherwisenot dirty metaslab fro the next TXGand set
metaslab_condense_wantedif the spacemaps were just upgraded (meaning we just enabled the
SPACEMAP_HISTOGRAM feature through upgrade).
This patch adds a new flag as a parameter to
metaslab_weight()andmetaslab_set_fragmentation()making the dirtying of the metaslaboptional.
Signed-off-by: Serapheim Dimitropoulos serapheim@delphix.com
Types of changes
Checklist:
Signed-off-by.