zio_decompress_data always ASSERTs successful decompression #9630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulZ-98
force-pushed
the
zdb_decompression
branch
from
72f9da3 to
b2d1cf7
Compare
Codecov Report
@@ Coverage Diff @@
## master #9630 +/- ##
========================================
+ Coverage 79% 79% +<1%
========================================
Files 418 418
Lines 123577 123589 +12
========================================
+ Hits 97951 97990 +39
+ Misses 25626 25599 -27
Continue to review full report at Codecov.
|
behlendorf
reviewed
Nov 27, 2019
PaulZ-98
force-pushed
the
zdb_decompression
branch
from
b2d1cf7 to
2d61a0f
Compare
behlendorf
approved these changes
Dec 6, 2019
|
missed previous update with |
|
I will rebase making sure to pick up the most recent zdb related changes, and update the description above to reflect what we decided to do. |
PaulZ-98
force-pushed
the
zdb_decompression
branch
from
2d61a0f to
72619fd
Compare
behlendorf
approved these changes
Dec 9, 2019
ghost
reviewed
Dec 10, 2019
|
give me please 1-2 days on testing. if it is critical, you can merge it and i'll report tests/review results later. |
|
Later today I will be addressing the test procedure issue that @freqlabs pointed out. |
This interferes with zdb_read_block trying all the decompression algorithms when the 'd' flag is specified, as some are expected to fail. Also control the output when guessing algorithms, try the more common compression types first, allow specifying lsize/psize, and fix an uninitialized variable. Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Fixes openzfs#9612
PaulZ-98
force-pushed
the
zdb_decompression
branch
from
72619fd to
98f7544
Compare
behlendorf
added
Status: Accepted
|
|
Thanks for checking @ikozhukhov |
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 26, 2019
This interferes with zdb_read_block trying all the decompression algorithms when the 'd' flag is specified, as some are expected to fail. Also control the output when guessing algorithms, try the more common compression types first, allow specifying lsize/psize, and fix an uninitialized variable. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Closes openzfs#9612 Closes openzfs#9630
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
This interferes with zdb_read_block trying all the decompression algorithms when the 'd' flag is specified, as some are expected to fail. Also control the output when guessing algorithms, try the more common compression types first, allow specifying lsize/psize, and fix an uninitialized variable. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Closes openzfs#9612 Closes openzfs#9630
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
This interferes with zdb_read_block trying all the decompression algorithms when the 'd' flag is specified, as some are expected to fail. Also control the output when guessing algorithms, try the more common compression types first, allow specifying lsize/psize, and fix an uninitialized variable. Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Closes #9612 Closes #9630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zio_decompress_data affects zdb by always ASSERTing successful decompression
This interferes with zdb_read_block trying all the decompression algoirithms when the 'd' flag is specified, as some are expected to fail. Also control the output when guessing algorithms, try the more common compression types first, allow specifying lsize/psize, and fix an uninitialized variable.
Signed-off-by: Paul Zuchowski pzuchowski@datto.com
Fixes #9612
Motivation and Context
Improve the behavior of zdb -R with the 'd' flag for decompression. As noted above, not all the use cases are working.
Description
Remove the ASSERT. Control the output when guessing algorithms by adding a 'v' verbose flag.
Try the more common compression types first.
Allow specifying lsize/psize to limit the upper range of the decompressed size when guessing. (You can copy and paste lsize/psize from the block pointer output.). Examples:
Fix an uninitialized variable dmu_objset_stats_t dds in dump_objset() which results in random false positive for inconsistent dataset in zdb output.
Eliminate the 'p' flag for -R since it is never used.
Man page changes.
How Has This Been Tested?
Manually, and created a zfs test for the decompression features.
Types of changes
Checklist:
Signed-off-by.