Fix zdb_read_block using zio after it is destroyed. #9657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
reviewed
Dec 2, 2019
PaulZ-98
force-pushed
the
zdb_checksum_fix
branch
from
ff5e97c to
88ffe5f
Compare
behlendorf
approved these changes
Dec 2, 2019
The checksum display code of zdb_read_block uses a zio to read in the block and then calls zio_checksum_compute. Use a new zio in the call to zio_checksum_compute not the zio from the read which has been destroyed by zio_wait. Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Fixes openzfs#9644
PaulZ-98
force-pushed
the
zdb_checksum_fix
branch
from
88ffe5f to
de552e5
Compare
|
Wasn't sure if you fixed the style issue so just pushed that change. |
Codecov Report
@@ Coverage Diff @@
## master #9657 +/- ##
==========================================
+ Coverage 79.32% 79.47% +0.15%
==========================================
Files 418 418
Lines 123544 123549 +5
==========================================
+ Hits 98003 98194 +191
+ Misses 25541 25355 -186
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
|
Looks good. Let's just hold off until @ikozhukhov can verify the fix on dilos. |
|
confirm: new update fixed my problem, thanks! |
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 26, 2019
The checksum display code of zdb_read_block uses a zio to read in the block and then calls zio_checksum_compute. Use a new zio in the call to zio_checksum_compute not the zio from the read which has been destroyed by zio_wait. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Igor Kozhukhov <igor@dilos.org> Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Closes openzfs#9644 Closes openzfs#9657
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
The checksum display code of zdb_read_block uses a zio to read in the block and then calls zio_checksum_compute. Use a new zio in the call to zio_checksum_compute not the zio from the read which has been destroyed by zio_wait. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Igor Kozhukhov <igor@dilos.org> Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Closes openzfs#9644 Closes openzfs#9657
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
The checksum display code of zdb_read_block uses a zio to read in the block and then calls zio_checksum_compute. Use a new zio in the call to zio_checksum_compute not the zio from the read which has been destroyed by zio_wait. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Igor Kozhukhov <igor@dilos.org> Signed-off-by: Paul Zuchowski <pzuchowski@datto.com> Closes #9644 Closes #9657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checksum display code of zdb_read_block uses a zio
to read in the block and then calls zio_checksum_compute.
Use a new zio in the call to zio_checksum_compute not the zio
from the read which has been destroyed by zio_wait.
Signed-off-by: Paul Zuchowski pzuchowski@datto.com
Fixes #9644
Motivation and Context
Test failure on DilOS - using a freed zio.
Description
When calling zio_checksum_compute, use a statically declared zio with io_bp and io_offset and io_spa set properly.
How Has This Been Tested?
Ran zfstest zdb section.
Types of changes
Checklist:
Signed-off-by.