-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the libzim.a generated by kiwix-build #12
Comments
Some useful information for testing the build failures when building with
In short, they appear to build correctly, but we are getting index and memory out of bounds errors in the console.log when using the WASM. |
@kelson42 If we have stable nightly and release builds of the libzim WASM binaries, as it seems we will from openzim/libzim#751, I'll be happy to work on this issue. But to do so, I need to merge #14, so that I'm not mixing up the issues in one enormous PR, and to keep the commit history logical. Could you kindly approve #14 so that I can continue (I could do some work on this on Thursday)? |
@mgautierfr Please make a new build of libzim so @Jaifroid can benefit of a stable version and not rely anymore on any nightly here. |
@Jaifroid Release has been done again. https://download.openzim.org/release/libzim/libzim_wasm-emscripten-8.1.0-1.tar.gz Should be good now. |
Excellent, I'll get to it. |
@mgautierfr You'll be pleased to know that this Repo is now building nightly versions based on the nightly wasm binaries provided by kiwix-build, e.g. https://download.openzim.org/nightly/2022-12-13/, and also that the default for a Release build is to use the latest released binaries from kiwix-build. Thank you very much for all your hard work and collaboration that made this possible. 😊 I've released v0.1 based on latest kiwix-build release. I've retained the ability to build everything from source for reasons of troubleshooting and customization (especially relating to #17 and #11). |
@mgautierfr @Jaifroid Pretty glad to see this finally happening. Kudos to both of you and @mossroy and @dattaz for the initial push. |
The Makefile could be modified to take a provided libzim.a (from the CI), instead of recompiling it from scratch
Beware of the potential issues that could happen if different versions of emscripten are used to compile libzim.a and this Makefile
The text was updated successfully, but these errors were encountered: