Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NODEFS for Electron builds #33

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Add NODEFS for Electron builds #33

merged 3 commits into from
Dec 13, 2022

Conversation

Jaifroid
Copy link
Collaborator

@Jaifroid Jaifroid commented Dec 11, 2022 •
edited
Loading

Fixes #26.

@Jaifroid Jaifroid added enhancement New feature or request build Code relating to building or publishing assets labels Dec 11, 2022
@Jaifroid Jaifroid self-assigned this Dec 11, 2022
@Jaifroid Jaifroid mentioned this pull request Dec 11, 2022
Closed
@Jaifroid Jaifroid marked this pull request as draft December 12, 2022 05:10
@Jaifroid Jaifroid force-pushed the Update-makefile-to-build-Electron-version branch from 8a46b3a to 7bc51e2 Compare December 13, 2022 22:42
@Jaifroid Jaifroid marked this pull request as ready for review December 13, 2022 22:45
@Jaifroid
Copy link
Collaborator Author

Tested and working in both Windows (portable and installable) and Linux (AppImage).

@Jaifroid Jaifroid merged commit d6d5725 into main Dec 13, 2022
@Jaifroid Jaifroid deleted the Update-makefile-to-build-Electron-version branch December 13, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jaifroid Jaifroid

Labels
build Code relating to building or publishing assets enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to read File arrayBuffers in Electron
1 participant
@Jaifroid