Be able to open zim archive from several fds. #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloman-yunkan
requested changes
Feb 23, 2024
mgautierfr
force-pushed
the
archive_fds
branch
from
f3a9689
to
a8bc501
Compare
mgautierfr
force-pushed
the
archive_fds
branch
from
a8bc501
to
d9a0144
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
==========================================
+ Coverage 57.63% 57.77% +0.14%
==========================================
Files 99 100 +1
Lines 4596 4616 +20
Branches 1926 1935 +9
==========================================
+ Hits 2649 2667 +18
+ Misses 675 669 -6
- Partials 1272 1280 +8 ☔ View full report in Codecov by Sentry. |
FilePart don't have to "map" the whole file on the FS. Only a section of the file may be a part of our archive. (Think about file parts being stored in a zip)
Has FilePart now have offsets, we can move the "offset concept" out of FileImpl. FileImpl always read from "offset" 0 in FileCompound. If it appears that we have an offset inside a file, it will be FilePart which will handle it.
mgautierfr
force-pushed
the
archive_fds
branch
from
d9a0144
to
7a18e5b
Compare
|
Ready for a (final) review. Missing coverage is about error handling code, which is difficult to test as we need to generate io errors. |
veloman-yunkan
approved these changes
Feb 27, 2024
Close opened file descriptor in test before checking equivalence.
mgautierfr
force-pushed
the
archive_fds
branch
from
7a18e5b
to
57fa6f1
Compare
|
Two suggested improvements have been followed. Directly rebased/fixup. |
mgautierfr
added a commit
that referenced
this pull request
Mar 8, 2024
Pr #860 removed the constructor from (fd, offset, size). This is a API break and we don't want that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #841
The tests in this PR need a update of zim-testing-suite (openzim/zim-testing-suite#7)