Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI with GitHub actions #892

Closed
wants to merge 8 commits into from
Closed

Windows CI with GitHub actions #892

wants to merge 8 commits into from

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    5b444ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    09d0b3e View commit details
    Browse the repository at this point in the history
  3. No werror=true

    mgautierfr committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8a5ab1d View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Make internal classes LIBZIM_API.

    While they are internal (and not part of public API), unittest are testing
    them and so we need to link to them.
    mgautierfr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    d0e4eb6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8ace7c View commit details
    Browse the repository at this point in the history
  3. Do not use static member (zimMajorVersion) in inlined constructor.

    On Windows, static members are not exported in dll.
    So we must not use them in inlined method/constructor.
    mgautierfr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    27d32ba View commit details
    Browse the repository at this point in the history
  4. Remove template feature

    mgautierfr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c930ed6 View commit details
    Browse the repository at this point in the history
  5. Do not unconditionally include search/xapian features

    On Windows, if we declare a exported class, the implementation of this
    class is expected in the dll.
    
    When compiling without xapian we must not include headers for which we
    don't compile the implementation.
    mgautierfr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3dc8833 View commit details
    Browse the repository at this point in the history