-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead links to categories / Support categories #15
Comments
Yes, categories are not mirrored. This is a work to do in mwoffliner. Probablyt the top priority. |
@ISNIT0 Here is currently the TOP priority topic on mwoffliner. It's not extremly complicated but need a bit work. Let me know if you are interested to have a look so I can explain you a bit. |
@kelson42 I'm interested :) What's the best place to start looking? |
@ISNIT0 Let's make a video conf about that. Let me know when you have time. |
Was 'probably the top priority' in Sept of 2016 yet still not implemented. Any time frame? |
No, it is still the top priority, but there is nobody to work on this so far. |
Thanks for pointing me to this. Hope to see it fixed sometime soon. Maybe a google summer of code project for someone? |
@WikiDocJames Maybe even if this first GSoC we are managing is focus on Kiwix-Android. That said if someone comes to me and is motivated and capable, I might consider to mentor it myself. |
Further Context: this issue directly affects Haiti schools who've made clear they would use Vikidia IF its link ("84 super articles") were clickable in the top right, as seen in the current Vikidia ZIM here: Current Vikidia ZIM downloaded from: Compare the original (online) version at https://fr.vikidia.org works far better. However the offline version (above ZIM file) is extremely frustrating to educators or children, when the most important link ("84 super articles") is not yet fixed — in future these essential materials should appear much like they do online here: PS @kelson42 has clarified that he's hopeful this will be fixed before the end of 2018. |
Things to do (the ones I can see):
|
What is the best thing to do for an articleList selection? Keep all the many parent categories? Not keep categories? Keep only one level of categories? Something else? |
@ISNIT0 Keep each category with at least one non-category child and merge all categories (to the top one) if there is only one sub-category. |
What about categories with media? e.g. https://commons.wikimedia.org/wiki/Category:Birds_in_art |
There doesn't seem to be a way to get the structured data of what order to show the sub-categories in. It's not just Alphabetical: and Any suggestions here @Popolechien? The query I'm currently using is this: https://bm.wikipedia.org/w/api.php?action=query&list=categorymembers&cmtype=subcat&cmlimit=500&format=json&cmtitle=Cat%C3%A9gorie%3ALien_th%C3%A9matique_pour_cat%C3%A9gories |
Progress: Each article has a TODO:
|
It seems to display the categories in the same way as MediaWiki displays them, we need information that isn't available through the API. Instead I'm just grouping them Alphabetically which is pretty close |
Progress so far: Known issues:
|
Yeah, the hidden categories not being weeded out is a real blocker. These are useless and take up quite some space. @ISNIT0 what's your plan about those? |
@Popolechien I've just updated the comment above, we're now not scraping them at all. Is this okay? |
perfect. |
@kelson42 @Popolechien
|
Niiiice. |
BM Full nopic: https://framadrop.org/r/cyk0sHthFk#vjOsZMdLvq9vqrulrpSOO/WUqSAlZ7ehMf6Zv36aVy0= No, the current logic is to check each article for categories as it's downloaded. Then we only end up with categories that contain at least one article as per @kelson42's spec:
|
I have tested with https://framadrop.org/r/D1EE0C6YxL#SwJO6719lYGfukNN1i71HHy1glAK4MaJTdKiifDHBlo=:
|
@kelson42 What do you mean by "Up categories should be migrated too"? |
@ISNIT0 In mean "categories parent categories", the full ancestor three should be downloaded (but of course in a simplified version). |
@kelson42 You previously said:
|
@ISNIT0 @kelson42 @Popolechien thanks a lot for working on this - I think the addition of live category links will make for a huge improvement! So far I've been working with Kirundi/Kynarwanda/French zims for use in refugee camps and they also appeared with dead links on the index.html page. Are you thinking of applying these changes (active category links) to all zims currently available for download via the kiwix website? |
@samkellerhals This is the goal, might take a few additional months to see it happening everywhere. |
@kelson42 This is now doing the tree-shaking/graph simplification: Because this is done using the top 100 articles, there is not a lot of shared categorisation, but |
@kelson42 I'd like to move the namespacing item you mentioned into a separate ticket and add it to 2.0 I can see it causing lots of back-and-forth with routing edge-cases |
@ISNIT0 From what I can see from last file you have proposed https://framadrop.org/r/P1S5xi6PRm#A6fiUMsysQsdZzr72yXsT6i/QaYm/Dc97iJZZtYktVg= This looks quite good :) That said I was not able to check if the pagination works fine! Do you have a demo ZIM for that? |
AFAIK everything has now been implemented in 1.9, except #762 to be done in 2.0 |
Wikisource home page directly links to categories for books - however this is not correctly handled and most links are unclickable.
The text was updated successfully, but these errors were encountered: