Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last pieces of local Parsoid code #1713

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

kelson42
Copy link
Collaborator

@kelson42 kelson42 commented Jan 5, 2023

Fixes #1690

$ mw --mwApiPath=/w/api.php --mwModulePath=/w/load.php --mwUrl=https://bulbapedia.bulbagarden.net/ --mwWikiPath=/wiki/ --verbose --webp --articleList=articles
[log] [2023-01-05T15:39:46.138Z] Successfully logged in S3
[log] [2023-01-05T15:39:46.631Z] closing sanitize redis DB
[log] [2023-01-05T15:39:46.632Z] Starting mwoffliner v1.11.12...
[info] [2023-01-05T15:39:46.652Z] Using custom flavour: no
[log] [2023-01-05T15:39:46.997Z] Successfully logged in S3
[log] [2023-01-05T15:39:47.002Z] Getting text direction...
[log] [2023-01-05T15:39:47.004Z] Getting site info...
[log] [2023-01-05T15:39:47.004Z] Getting sub-title...
[info] [2023-01-05T15:39:47.006Z] Downloading [https://bulbapedia.bulbagarden.net/wiki/]
[info] [2023-01-05T15:39:47.008Z] Getting JSON from [https://bulbapedia.bulbagarden.net/w/api.php?action=query&meta=siteinfo&format=json&siprop=general|namespaces|statistics|variables|category|wikidesc]
[info] [2023-01-05T15:39:47.010Z] Downloading [https://bulbapedia.bulbagarden.net/wiki/]
[log] [2023-01-05T15:39:47.445Z] Text direction is [ltr]
[info] [2023-01-05T15:39:49.358Z] Getting JSON from [https://bulbapedia.bulbagarden.net/w/api.php?action=query&format=json&prop=redirects%7Crevisions%7Ccoordinates&rdlimit=max&rdnamespace=]
[info] [2023-01-05T15:39:49.475Z] Coordinates not available on this wiki
[log] [2023-01-05T15:39:49.475Z] Base Url:  undefined
[log] [2023-01-05T15:39:49.476Z] Base Url for Main Page:  undefined
Failed to run mwoffliner after [4s]: {
	"stack": "Error: Unable to find appropriate API end-point to retrieve article HTML\n    at Downloader.<anonymous> (/home/kelson/code/mwoffliner/src/Downloader.ts:238:13)\n    at Generator.next (<anonymous>)\n    at /home/kelson/code/mwoffliner/src/Downloader.ts:27:71\n    at new Promise (<anonymous>)\n    at __awaiter (/home/kelson/code/mwoffliner/src/Downloader.ts:23:12)\n    at Downloader.setBaseUrls (/home/kelson/code/mwoffliner/src/Downloader.ts:233:16)\n    at Object.<anonymous> (/home/kelson/code/mwoffliner/src/mwoffliner.lib.ts:214:20)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/kelson/code/mwoffliner/src/mwoffliner.lib.ts:26:58)\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)",
	"message": "Unable to find appropriate API end-point to retrieve article HTML"
}


**********

Unable to find appropriate API end-point to retrieve article HTML

**********

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 68.96% // Head: 68.97% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cc7b6d2) compared to base (fd4a812).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1713   +/-   ##
=======================================
  Coverage   68.96%   68.97%           
=======================================
  Files          26       26           
  Lines        2417     2411    -6     
  Branches      475      473    -2     
=======================================
- Hits         1667     1663    -4     
+ Misses        585      583    -2     
  Partials      165      165           
Impacted Files Coverage Δ
src/Downloader.ts 68.60% <ø> (+0.03%) ⬆️
src/mwoffliner.lib.ts 67.00% <ø> (ø)
src/parameterList.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@pavel-karatsiuba pavel-karatsiuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit d116342 into main Jan 5, 2023
@kelson42 kelson42 deleted the remove-last-pieces-of-local-parsoid branch January 5, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulbagarden Zimfarm rule doesn't work for several months
2 participants