Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages updated. Configs changed to use ESM #1715

Merged
merged 7 commits into from
Jan 18, 2023

Conversation

pavel-karatsiuba
Copy link
Contributor

@pavel-karatsiuba pavel-karatsiuba commented Jan 6, 2023

Fixes #1688
Fixes #1667
Fixes #1732

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Base: 70.71% // Head: 69.03% // Decreases project coverage by -1.69% ⚠️

Coverage data is based on head (c480dd1) compared to base (844e4d8).
Patch coverage: 76.92% of modified lines in pull request are covered.

❗ Current head c480dd1 differs from pull request most recent head e314b20. Consider uploading reports for the commit e314b20 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
- Coverage   70.71%   69.03%   -1.69%     
==========================================
  Files          27       23       -4     
  Lines        2698     2503     -195     
  Branches      619      614       -5     
==========================================
- Hits         1908     1728     -180     
+ Misses        790      665     -125     
- Partials        0      110     +110     
Impacted Files Coverage Δ
src/Dump.ts 80.76% <ø> (-1.22%) ⬇️
src/MediaWiki.ts 78.94% <ø> (+0.15%) ⬆️
src/Redis.ts 60.00% <ø> (-15.00%) ⬇️
src/S3.ts 0.00% <0.00%> (-10.21%) ⬇️
src/stores.ts 100.00% <ø> (ø)
src/util/articleListMainPage.ts 33.33% <ø> (-23.81%) ⬇️
src/util/articleRenderers.ts 61.45% <ø> (-2.27%) ⬇️
src/util/categories.ts 0.00% <ø> (-5.64%) ⬇️
src/util/mw-api.ts 88.50% <ø> (-0.51%) ⬇️
src/util/redirects.ts 100.00% <ø> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pavel-karatsiuba pavel-karatsiuba marked this pull request as ready for review January 14, 2023 09:24
@kelson42 kelson42 force-pushed the migrate-to-esm-update-packages branch from 2b64584 to b7ccb85 Compare January 15, 2023 15:50
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md should be updated. ./node_modules/.bin/ts-node ./src/cli.ts --mwUrl=https://bm.wikipedia.org does not work anymore. There is also a problem with the example to run a specific test:

  • test/e2e/localParsoid.test.ts does not exist anymore
  • Not clear what test:pattern-coverage and test:pattern mean?

… to CI.

CONTRIBUTING.md fixed with right commands.
@pavel-karatsiuba
Copy link
Contributor Author

  • Not clear what test:pattern-coverage and test:pattern mean?

test:pattern uses to execute tests by some template. For example all tests which are ends on 's3.test.ts': test:pattern s3.test.ts

@kelson42
Copy link
Collaborator

@pavel-karatsiuba So it accepts a regex?

@pavel-karatsiuba
Copy link
Contributor Author

@kelson42 Yes, it is possible to run test suites by providing a regex.

@kelson42
Copy link
Collaborator

@pavel-karatsiuba Woukd be helpful then to see tgis in the example you have given.

@kelson42 kelson42 merged commit fbabd74 into main Jan 18, 2023
@kelson42 kelson42 deleted the migrate-to-esm-update-packages branch January 18, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error? by running tests Migrate to ESM format Update all dependences to latest version
2 participants