-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages updated. Configs changed to use ESM #1715
Conversation
32cff50
to
7374f41
Compare
Codecov ReportBase: 70.71% // Head: 69.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1715 +/- ##
==========================================
- Coverage 70.71% 69.03% -1.69%
==========================================
Files 27 23 -4
Lines 2698 2503 -195
Branches 619 614 -5
==========================================
- Hits 1908 1728 -180
+ Misses 790 665 -125
- Partials 0 110 +110
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2b64584
to
b7ccb85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CONTRIBUTING.md
should be updated. ./node_modules/.bin/ts-node ./src/cli.ts --mwUrl=https://bm.wikipedia.org
does not work anymore. There is also a problem with the example to run a specific test:
test/e2e/localParsoid.test.ts
does not exist anymore- Not clear what
test:pattern-coverage
andtest:pattern
mean?
… to CI. CONTRIBUTING.md fixed with right commands.
|
@pavel-karatsiuba So it accepts a regex? |
@kelson42 Yes, it is possible to run test suites by providing a regex. |
@pavel-karatsiuba Woukd be helpful then to see tgis in the example you have given. |
Fixes #1688
Fixes #1667
Fixes #1732